[DIRMINA-1148] NPE in Socks4LogicHandler

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.1.4
• Fix Version/s: 2.2.0
• Assignee: Unassigned
• Reporter: Grzegorz Grzybek
• Created: 06/Sep/21 10:07
• Updated: 14/Sep/21 17:58
• Resolved: 14/Sep/21 17:58

Description

SOCKS4 0x01 packet (establish a TCP/IP stream connection) may contain ID field to send variable-length, null-terminated user ID. However the code in org.apache.mina.proxy.handlers.socks.Socks4LogicHandler#writeRequest simply contains:

byte[] userID = request.getUserName().getBytes("ASCII");

leading to NPE, when the user ID is not set. For example camel-quickfix uses mina through quickfix-j library and username is optional.