[DIRMINA-1061] When AbstractPollingIoProcessor read nothing, free the temporary buffer should be better

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.16
• Fix Version/s: 2.0.17
• Component/s: Core
• Assignee: Unassigned
• Reporter: Mark
• Created: 16/Dec/16 04:01
• Updated: 26/Dec/16 17:37
• Resolved: 26/Dec/16 17:37

Description

org.apache.mina.core.polling.AbstractPollingIoProcessor.java

private void read(S session) {
        IoSessionConfig config = session.getConfig();
        int bufferSize = config.getReadBufferSize();
        IoBuffer buf = IoBuffer.allocate(bufferSize);
//...
//...
            if (readBytes > 0) {
                IoFilterChain filterChain = session.getFilterChain();
                filterChain.fireMessageReceived(buf);
                buf = null;

                if (hasFragmentation) {
                    if (readBytes << 1 < config.getReadBufferSize()) {
                        session.decreaseReadBufferSize();
                    } else if (readBytes == config.getReadBufferSize()) {
                        session.increaseReadBufferSize();
                    }
                }
            }

it seems that this method will be called when session closing.
it'll better to call buf.free() if readBytes==0, to help allocator recycle this buffer, thx!