Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: core
    • Labels:
      None

      Description

      Externalize configurations to a file so customers can tweak DirectMemory system settings from conf

        Activity

        Hide
        Gaurav Sharma added a comment -

        Thanks Raffaele.

        Show
        Gaurav Sharma added a comment - Thanks Raffaele.
        Hide
        Raffaele P. Guidi added a comment -

        the refactoring worked

        Show
        Raffaele P. Guidi added a comment - the refactoring worked
        Hide
        Raffaele P. Guidi added a comment -

        I refactored a bit and added a simple properties file configuration as well. All tests pass on my laptop - if jenkins says it's ok I'll close the ticket. Gaurav, feel free to review and propose improvements and thanks for your contribution

        Show
        Raffaele P. Guidi added a comment - I refactored a bit and added a simple properties file configuration as well. All tests pass on my laptop - if jenkins says it's ok I'll close the ticket. Gaurav, feel free to review and propose improvements and thanks for your contribution
        Hide
        Gaurav Sharma added a comment -

        Thanks Raffaele. Today has been a bit busy at work and I have not had a chance to test the osgi integration; will get to this tomorrow and get back to you.

        Show
        Gaurav Sharma added a comment - Thanks Raffaele. Today has been a bit busy at work and I have not had a chance to test the osgi integration; will get to this tomorrow and get back to you.
        Hide
        Raffaele P. Guidi added a comment -

        In any case the module is in svn but is not enabled in the pom until I can manage to fix the OSGi integration. I also suspect that a simple properties file would be a perfect solution to start with - and with less impact - but I would like to understand what I'm doing wrong here

        Show
        Raffaele P. Guidi added a comment - In any case the module is in svn but is not enabled in the pom until I can manage to fix the OSGi integration. I also suspect that a simple properties file would be a perfect solution to start with - and with less impact - but I would like to understand what I'm doing wrong here
        Hide
        Gaurav Sharma added a comment -

        Maybe we can just rollback to the prev. version:
        svn merge -r r1370059:r1370054 .

        per: http://svnbook.red-bean.com/en/1.2/svn.branchmerge.commonuses.html#svn.branchmerge.commonuses.undo

        Show
        Gaurav Sharma added a comment - Maybe we can just rollback to the prev. version: svn merge -r r1370059:r1370054 . per: http://svnbook.red-bean.com/en/1.2/svn.branchmerge.commonuses.html#svn.branchmerge.commonuses.undo
        Hide
        Raffaele P. Guidi added a comment -

        Sure, or protostuff which is already in use, but this patch is ready and could be a good start

        Show
        Raffaele P. Guidi added a comment - Sure, or protostuff which is already in use, but this patch is ready and could be a good start
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        maybe we could use jackson which can support multiple format ?

        Show
        Olivier Lamy (*$^¨%`£) added a comment - maybe we could use jackson which can support multiple format ?
        Hide
        Raffaele P. Guidi added a comment -

        Yep. Can you produce it again? I had some problems with pom.xml (hence the mistake) with the last one

        Show
        Raffaele P. Guidi added a comment - Yep. Can you produce it again? I had some problems with pom.xml (hence the mistake) with the last one
        Hide
        Gaurav Sharma added a comment -

        yeah, iirc, it was. so, we re-roll the patch then?

        Show
        Gaurav Sharma added a comment - yeah, iirc, it was. so, we re-roll the patch then?
        Hide
        Raffaele P. Guidi added a comment -

        maybe I got it wrong, it seems that OSGi compatibility has been provided [1] probably I exported org.yaml.* instead of org.yaml.snakeyml.* ...sorry, my OSGi is a bit rusty maybe Ioannis Cannellos could help here?

        [1] http://code.google.com/p/snakeyaml/issues/detail?id=96

        Show
        Raffaele P. Guidi added a comment - maybe I got it wrong, it seems that OSGi compatibility has been provided [1] probably I exported org.yaml.* instead of org.yaml.snakeyml.* ...sorry, my OSGi is a bit rusty maybe Ioannis Cannellos could help here? [1] http://code.google.com/p/snakeyaml/issues/detail?id=96
        Hide
        Raffaele P. Guidi added a comment -

        I rolled back the changes as snakeyml is not OSGi compliant and all OSGi related tests did not succeed. We have to find a different YAML implementation

        Show
        Raffaele P. Guidi added a comment - I rolled back the changes as snakeyml is not OSGi compliant and all OSGi related tests did not succeed. We have to find a different YAML implementation
        Hide
        Raffaele P. Guidi added a comment -

        I'm working on this (just having some git/svn trouble) only thing I changed is the location of the configuration file (I read it from the classpath) and I removed the other stuff in pom.xml

        Show
        Raffaele P. Guidi added a comment - I'm working on this (just having some git/svn trouble) only thing I changed is the location of the configuration file (I read it from the classpath) and I removed the other stuff in pom.xml
        Hide
        Gaurav Sharma added a comment -

        Also add the felix maven bundle plugin to work around some m2e issues. Please revert if unnecessary.

        Show
        Gaurav Sharma added a comment - Also add the felix maven bundle plugin to work around some m2e issues. Please revert if unnecessary.
        Hide
        Gaurav Sharma added a comment - - edited

        Patch attached. The only existing file modified is the base pom; all others are new files. Please review. Thank you.

        Show
        Gaurav Sharma added a comment - - edited Patch attached. The only existing file modified is the base pom; all others are new files. Please review. Thank you.
        Hide
        Gaurav Sharma added a comment - - edited

        The most basic question is regarding update-ability of the various properties at runtime. If there is no requirement for runtime updates by updating the config on disk, then we load all properties as singletons during the entire lifetime; otherwise, I will have it so they mirror on-disk updates. The latter will require us to segregate singleton and update-able property keys.

        Show
        Gaurav Sharma added a comment - - edited The most basic question is regarding update-ability of the various properties at runtime. If there is no requirement for runtime updates by updating the config on disk, then we load all properties as singletons during the entire lifetime; otherwise, I will have it so they mirror on-disk updates. The latter will require us to segregate singleton and update-able property keys.

          People

          • Assignee:
            Raffaele P. Guidi
            Reporter:
            Gaurav Sharma
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development