[DIRAPI-96] Connection leak in LdapConnectionPool.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.0-M13
• Assignee: Emmanuel Lécharny
• Reporter: Damien Dubé
• Created: 15/Nov/12 21:33
• Updated: 08/Jan/15 17:17
• Resolved: 15/Nov/12 23:54

Description

If a Connection fails on credentials, the LdapConnection is not closed and is not in the pool.

I modified the makeObject() function in PoolableLdapConnectionFactory.java to this and it does the trick.

public Object makeObject() throws Exception
{
LOG.debug("creating a LDAP connection");

LdapNetworkConnection connection = new LdapNetworkConnection(config);
try

{ connection.bind(config.getName(), config.getCredentials()); }

catch (Exception e1) {
try

{ connection.close(); }

catch (Exception e2) {

}
throw e1;
}
return connection;
}

Issue Links

• is cloned by: DIRAPI-97 Unreliable LdapConnectionPool: org.apache.directory.ldap.client.api.exception.InvalidConnectionException: Cannot connect on the server, the connection is invalid
• relates to: DIRAPI-97 Unreliable LdapConnectionPool: org.apache.directory.ldap.client.api.exception.InvalidConnectionException: Cannot connect on the server, the connection is invalid