[DIRAPI-303] If and else-if branches has the same condition

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0-RC2
• Fix Version/s: 2.0.0.AM3
• Assignee: Unassigned
• Reporter: songwanging
• Created: 08/Dec/17 17:04
• Updated: 12/May/19 05:54
• Resolved: 26/Dec/17 09:34

Description

Our tool DeepTect has detected a piece of buggy code snippet, in which the if and else branches has the same condition.

Path: directory-ldap-api/util/src/main/java/org/apache/directory/api/util/Unicode.java

public static char bytesToChar( byte[] bytes, int pos ){
...
   else if ( ( bytes[pos] & UTF8_FIVE_BYTES_MASK ) == UTF8_FIVE_BYTES ){
             // Five bytes char
             ...
    }
   else if ( ( bytes[pos] & UTF8_FIVE_BYTES_MASK ) == UTF8_FIVE_BYTES ){
                // Six bytes char
                 ...
            }