Directory Client API
  1. Directory Client API
  2. DIRAPI-113

Distribution module should generate GPG/PGP signatures and MD5/SHA checksums

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.0-RC1
    • Labels:
      None

      Description

      The 'distribution' module creates the source and binary archives (zip and tar.gz) but doesn't create signatures and checksums. This should be done automatically during the release.

      1. sign.patch
        0.5 kB
        Felix Knecht

        Activity

        Stefan Seelmann created issue -
        Emmanuel Lecharny made changes -
        Field Original Value New Value
        Fix Version/s 1.0.0-M5 [ 12316454 ]
        Fix Version/s 1.0.0-M4 [ 12316357 ]
        Pierre-Arnaud Marcelot made changes -
        Fix Version/s 1.0.0-M6 [ 12316853 ]
        Fix Version/s 1.0.0-M5 [ 12316454 ]
        Hide
        Pierre-Arnaud Marcelot added a comment -

        Moving issues to the latest non-released version.

        Show
        Pierre-Arnaud Marcelot added a comment - Moving issues to the latest non-released version.
        Pierre-Arnaud Marcelot made changes -
        Fix Version/s 1.0.0-M9 [ 12317856 ]
        Fix Version/s 1.0.0-M6 [ 12316853 ]
        Hide
        Felix Knecht added a comment -

        maven-gpg-plugin signs attached artifacts. By default (http://maven.apache.org/plugins/maven-assembly-plugin/single-mojo.html) assembly attaches the built artifacts, but this is here disable by configuration. I don't know if this is done because of any needs. If not, it can be removed (or set to 'true') to have the assembled artifacts signed.
        Patch just removes the line for disabling attachement and uses default.

        Show
        Felix Knecht added a comment - maven-gpg-plugin signs attached artifacts. By default ( http://maven.apache.org/plugins/maven-assembly-plugin/single-mojo.html ) assembly attaches the built artifacts, but this is here disable by configuration. I don't know if this is done because of any needs. If not, it can be removed (or set to 'true') to have the assembled artifacts signed. Patch just removes the line for disabling attachement and uses default.
        Felix Knecht made changes -
        Attachment sign.patch [ 12501966 ]
        Hide
        Pierre-Arnaud Marcelot added a comment -

        Hi Felix,

        I tested the patch (with today's commit) and it generates the *.asc files.
        But unfortunately, no *.md5 and no *.sha1 file.

        Here's the files in the 'target' folder after 'mvn clean install -Papache-release':

        • additional-jars
        • apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.tar.gz
        • apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.tar.gz.asc
        • apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.tar.gz.asc.asc
        • apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.zip
        • apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.zip.asc
        • apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.zip.asc.asc
        • apache-ldap-api-1.0.0-M9-SNAPSHOT-src.tar.gz
        • apache-ldap-api-1.0.0-M9-SNAPSHOT-src.tar.gz.asc
        • apache-ldap-api-1.0.0-M9-SNAPSHOT-src.tar.gz.asc.asc
        • apache-ldap-api-1.0.0-M9-SNAPSHOT-src.zip
        • apache-ldap-api-1.0.0-M9-SNAPSHOT-src.zip.asc
        • apache-ldap-api-1.0.0-M9-SNAPSHOT-src.zip.asc.asc
        • apache-ldap-api-1.0.0-M9-SNAPSHOT.pom
        • apache-ldap-api-1.0.0-M9-SNAPSHOT.pom.asc
        • apache-ldap-api-1.0.0-M9-SNAPSHOT.pom.asc.asc
        • archive-tmp
        • maven-shared-archive-resources
        • rat.txt
        Show
        Pierre-Arnaud Marcelot added a comment - Hi Felix, I tested the patch (with today's commit) and it generates the *.asc files. But unfortunately, no *.md5 and no *.sha1 file. Here's the files in the 'target' folder after 'mvn clean install -Papache-release': additional-jars apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.tar.gz apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.tar.gz.asc apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.tar.gz.asc.asc apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.zip apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.zip.asc apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.zip.asc.asc apache-ldap-api-1.0.0-M9-SNAPSHOT-src.tar.gz apache-ldap-api-1.0.0-M9-SNAPSHOT-src.tar.gz.asc apache-ldap-api-1.0.0-M9-SNAPSHOT-src.tar.gz.asc.asc apache-ldap-api-1.0.0-M9-SNAPSHOT-src.zip apache-ldap-api-1.0.0-M9-SNAPSHOT-src.zip.asc apache-ldap-api-1.0.0-M9-SNAPSHOT-src.zip.asc.asc apache-ldap-api-1.0.0-M9-SNAPSHOT.pom apache-ldap-api-1.0.0-M9-SNAPSHOT.pom.asc apache-ldap-api-1.0.0-M9-SNAPSHOT.pom.asc.asc archive-tmp maven-shared-archive-resources rat.txt
        Hide
        Felix Knecht added a comment -

        IMO it does, you need to have a look in the your local maven repository, where the artifacts are installed:
        [felix@asgard ~]$ l .m2/repository/org/apache/directory/shared/apache-ldap-api/1.0.0-M9-SNAPSHOT/
        total 15460
        drwxrwxr-x 2 felix felix 4096 Nov 2 15:53 ./
        drwxrwxr-x 3 felix felix 4096 Nov 2 15:41 ../
        rw-rw-r- 1 felix felix 5041955 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.tar.gz
        rw-rw-r- 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.tar.gz.asc
        rw-rw-r- 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.tar.gz.asc.asc
        rw-rw-r- 1 felix felix 32 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.tar.gz.md5
        rw-rw-r- 1 felix felix 40 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.tar.gz.sha1
        rw-rw-r- 1 felix felix 5047550 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.zip
        rw-rw-r- 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.zip.asc
        rw-rw-r- 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.zip.asc.asc
        rw-rw-r- 1 felix felix 32 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.zip.md5
        rw-rw-r- 1 felix felix 40 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.zip.sha1
        rw-rw-r- 1 felix felix 4702 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT.pom
        rw-rw-r- 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT.pom.asc
        rw-rw-r- 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT.pom.asc.asc
        rw-rw-r- 1 felix felix 32 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT.pom.md5
        rw-rw-r- 1 felix felix 40 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT.pom.sha1
        rw-rw-r- 1 felix felix 1393407 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.tar.gz
        rw-rw-r- 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.tar.gz.asc
        rw-rw-r- 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.tar.gz.asc.asc
        rw-rw-r- 1 felix felix 32 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.tar.gz.md5
        rw-rw-r- 1 felix felix 40 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.tar.gz.sha1
        rw-rw-r- 1 felix felix 4226955 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.zip
        rw-rw-r- 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.zip.asc
        rw-rw-r- 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.zip.asc.asc
        rw-rw-r- 1 felix felix 32 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.zip.md5
        rw-rw-r- 1 felix felix 40 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.zip.sha1
        rw-rw-r- 1 felix felix 3430 Nov 2 15:53 maven-metadata-local.xml
        rw-rw-r- 1 felix felix 32 Nov 2 15:53 maven-metadata-local.xml.md5
        rw-rw-r- 1 felix felix 40 Nov 2 15:53 maven-metadata-local.xml.sha1
        rw-rw-r- 1 felix felix 852 Nov 2 15:53 _maven.repositories

        Show
        Felix Knecht added a comment - IMO it does, you need to have a look in the your local maven repository, where the artifacts are installed: [felix@asgard ~] $ l .m2/repository/org/apache/directory/shared/apache-ldap-api/1.0.0-M9-SNAPSHOT/ total 15460 drwxrwxr-x 2 felix felix 4096 Nov 2 15:53 ./ drwxrwxr-x 3 felix felix 4096 Nov 2 15:41 ../ rw-rw-r - 1 felix felix 5041955 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.tar.gz rw-rw-r - 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.tar.gz.asc rw-rw-r - 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.tar.gz.asc.asc rw-rw-r - 1 felix felix 32 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.tar.gz.md5 rw-rw-r - 1 felix felix 40 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.tar.gz.sha1 rw-rw-r - 1 felix felix 5047550 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.zip rw-rw-r - 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.zip.asc rw-rw-r - 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.zip.asc.asc rw-rw-r - 1 felix felix 32 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.zip.md5 rw-rw-r - 1 felix felix 40 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-bin.zip.sha1 rw-rw-r - 1 felix felix 4702 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT.pom rw-rw-r - 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT.pom.asc rw-rw-r - 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT.pom.asc.asc rw-rw-r - 1 felix felix 32 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT.pom.md5 rw-rw-r - 1 felix felix 40 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT.pom.sha1 rw-rw-r - 1 felix felix 1393407 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.tar.gz rw-rw-r - 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.tar.gz.asc rw-rw-r - 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.tar.gz.asc.asc rw-rw-r - 1 felix felix 32 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.tar.gz.md5 rw-rw-r - 1 felix felix 40 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.tar.gz.sha1 rw-rw-r - 1 felix felix 4226955 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.zip rw-rw-r - 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.zip.asc rw-rw-r - 1 felix felix 198 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.zip.asc.asc rw-rw-r - 1 felix felix 32 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.zip.md5 rw-rw-r - 1 felix felix 40 Nov 2 15:53 apache-ldap-api-1.0.0-M9-SNAPSHOT-src.zip.sha1 rw-rw-r - 1 felix felix 3430 Nov 2 15:53 maven-metadata-local.xml rw-rw-r - 1 felix felix 32 Nov 2 15:53 maven-metadata-local.xml.md5 rw-rw-r - 1 felix felix 40 Nov 2 15:53 maven-metadata-local.xml.sha1 rw-rw-r - 1 felix felix 852 Nov 2 15:53 _maven.repositories
        Hide
        Pierre-Arnaud Marcelot added a comment -

        Indeed. You're right.

        They are here in the Maven repository.

        But, I think the initial purpose of the JIRA was to have them generated inside the 'target' folder, as a way to easily copy these things to people.apache.org in the case of a release.

        The extra step of looking for the correct files in the Maven repository is not that complicated though...

        Show
        Pierre-Arnaud Marcelot added a comment - Indeed. You're right. They are here in the Maven repository. But, I think the initial purpose of the JIRA was to have them generated inside the 'target' folder, as a way to easily copy these things to people.apache.org in the case of a release. The extra step of looking for the correct files in the Maven repository is not that complicated though...
        Emmanuel Lecharny made changes -
        Fix Version/s 1.0.0-M9 [ 12317856 ]
        Emmanuel Lecharny made changes -
        Fix Version/s 1.0.0-M10 [ 12319509 ]
        Pierre-Arnaud Marcelot made changes -
        Fix Version/s 1.0.0-M11 [ 12319848 ]
        Fix Version/s 1.0.0-M10 [ 12319509 ]
        Pierre-Arnaud Marcelot made changes -
        Fix Version/s 1.0.0-M12 [ 12320057 ]
        Fix Version/s 1.0.0-M11 [ 12319848 ]
        Emmanuel Lecharny made changes -
        Fix Version/s 1.0.0-RC1 [ 12313151 ]
        Emmanuel Lecharny made changes -
        Fix Version/s 1.0.0-M12 [ 12320057 ]
        Emmanuel Lecharny made changes -
        Project Directory Shared [ 12310770 ] Directory Client API [ 12310962 ]
        Key DIRSHARED-122 DIRAPI-113
        Issue Type Task [ 3 ] Bug [ 1 ]
        Fix Version/s 1.0.0-RC1 [ 12315974 ]
        Fix Version/s 1.0.0-RC1 [ 12313151 ]
        Hide
        Kiran Ayyagari added a comment -

        Applied the patch here http://svn.apache.org/r1571204.
        And I would suggest we leave the generated checksum files as they
        are in the ~/.m2/repository/org/apache/directory/api/apache-ldap-api folder
        instead of copying them to 'target' folder.

        Show
        Kiran Ayyagari added a comment - Applied the patch here http://svn.apache.org/r1571204 . And I would suggest we leave the generated checksum files as they are in the ~/.m2/repository/org/apache/directory/api/apache-ldap-api folder instead of copying them to 'target' folder.
        Kiran Ayyagari made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Kiran Ayyagari [ akiran ]
        Resolution Fixed [ 1 ]
        Hide
        Emmanuel Lecharny added a comment -

        Closing the resolved issues.

        Show
        Emmanuel Lecharny added a comment - Closing the resolved issues.
        Emmanuel Lecharny made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Kiran Ayyagari [ akiran ] Emmanuel Lecharny [ elecharny ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        1040d 17h 24m 1 Kiran Ayyagari 24/Feb/14 09:51
        Resolved Resolved Closed Closed
        318d 7h 25m 1 Emmanuel Lecharny 08/Jan/15 17:16

          People

          • Assignee:
            Emmanuel Lecharny
            Reporter:
            Stefan Seelmann
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development