Commons Digester
  1. Commons Digester
  2. DIGESTER-85

[digester] Include filename or uri if Digester.parse(File file or String uri throws a SAXException

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

      Description

      Would make debugging easier.

      A try catch SAXException block around the getXMLReader().parse(input); statements in the parse
      File and parse(String would allow the SAX Exception to be caught, taken apart, an error statement
      with file or uri added, and thrown.

      But how to capture the first stack trace? Use NestedExceptions from jakarta-commons-lang? Use
      org.apache.commons.lang.exception.ExceptionUtils.getStackTrace and and cram the first stack
      trace in the with new SAXExceptions? Or avoid the new dependecy on lang and do something
      else?

        Activity

        Erik Meade created issue -
        Henri Yandell made changes -
        Field Original Value New Value
        issue.field.bugzillaimportkey 21903 12340873
        Henri Yandell made changes -
        Assignee Jakarta Commons Developers Mailing List [ commons-dev@jakarta.apache.org ]
        Key COM-722 DIGESTER-85
        Project Commons [ 12310458 ] Commons Digester [ 12310471 ]
        Component/s Digester [ 12311111 ]
        Affects Version/s unspecified [ 12311647 ]
        Henri Yandell made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Henri Yandell made changes -
        Status Closed [ 6 ] Reopened [ 4 ]
        Henri Yandell made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Won't Fix [ 2 ]
        Erik Meade made changes -
        Resolution Won't Fix [ 2 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Simone Tripodi made changes -
        Comment [ Fixed on Digester3 /trunk, see [r1140083|http://svn.apache.org/viewvc?view=revision&revision=1140083].

        There's no need to decorate the thrown exception, filename or uri have been logged at error level: since the request is focused on monitoring errors from 3rd-parties Digester use, logging which resource caused the error is more than enough. ]
        Simone Tripodi made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Assignee Simone Tripodi [ simone.tripodi ]
        Fix Version/s 3.0 [ 12316679 ]
        Resolution Fixed [ 1 ]
        Simone Tripodi made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Simone Tripodi
            Reporter:
            Erik Meade
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development