Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Trivial
-
Resolution: Fixed
-
Affects Version/s: 1.6
-
Fix Version/s: None
-
Labels:None
-
Environment:
Operating System: other
Platform: Other
-
Bugzilla Id:35097
Description
Recent musings on the CallMethodRule code brought to my notice an interesting
construct for obtaining the String class 
Inlining a patch, since its trivial:
Index: CallMethodRule.java
===================================================================
RCS file: /usr/local/cvsroot/apache/patches/commons-digester-1.6-
src/src/java/org/apache/commons/digester/CallMethodRule.java,v
retrieving revision 1.1
diff -c -r1.1 CallMethodRule.java
-
-
- CallMethodRule.java 27 May 2005 02:52:14 -0000 1.2
- CallMethodRule.java 27 May 2005 03:21:23 -0000
***************
262c262
< this.paramTypes[i] = "abc".getClass();
—
> this.paramTypes[i] = String.class;
330c330
< this.paramTypes[i] = "abc".getClass();
—
> this.paramTypes[i] = String.class;
503c503
< paramTypes[0] = "abc".getClass();
—
> paramTypes[0] = String.class;
-
-Rahul
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
(In reply to comment #1)
<snip>
> I think I would prefer to commit this change after the release
> rather than immediately before.
Please, take your time. I wouldn't want to introduce 0.01% doubt at this stage.
-Rahul
Committed as revision 190341. Thanks.
Changing reporter in order to close old account.
Yes, that existing code is a bit .. different.
I'm 99.99% sure that your change is correct. But as there isn't anything
*actually wrong with the existing code, and we are (hopefully) just a few days
from a release, I think I would prefer to commit this change after the release
rather than immediately before.
Unless you can see a situation where String.class works and "abc".getClass()
does not?