Commons Digester
  1. Commons Digester
  2. DIGESTER-118

ObjectCreateRule shouldn't keep className as a field

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 3.0
    • Labels:
      None

      Description

      Currently ObjectCreateRule refers to the class by using the name, but this is highly undesirable.

      1. "begin" uses the classloader that loaded Digester to resolve this class name, but this won't work in multi-classloader environment (like IDE, Maven, etc.)
      2. "begin" invokes the loadClass method each time a new object is created. This is unnecessary performance hit.

      The proper thing to do is to retain the Class object, and convert String to Class in the constructor.

        Activity

        Simone Tripodi made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Simone Tripodi made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Simone Tripodi [ simone.tripodi ]
        Fix Version/s 3.0 [ 12316679 ]
        Resolution Fixed [ 1 ]
        Kohsuke Kawaguchi created issue -

          People

          • Assignee:
            Simone Tripodi
            Reporter:
            Kohsuke Kawaguchi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development