Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8
    • Fix Version/s: 1.8.1
    • Labels:
      None

      Description

      Currently, 136 unit tests are run using maven and 149 unit tests are run using ant.

      The maven build uses the file patterns:
      **/*Test.java
      **/*TestCase.java
      which misses the following tests:
      **/plugins/TestAll.java
      **/TestFactoryCreate.java

      After the missing tests are added to the maven build, 157 tests are executed.

      The ant build does not execute the following tests:
      LocationTrackerTestCase
      NamespaceSnapshotTestCase
      OverlappingCallMethodRuleTestCase

      After the missing tests to the ant build, 157 tests are executed.

      I'm not sure how this should be fixed; should test cases that don't end in "Test" or "TestCase" be renamed?

      When this is fixed, it would be nice if the junit ant task were used to run the tests so that the JUnit report can be generated.

        Activity

        Hide
        Henri Yandell added a comment -

        Either run 'maven ant', or replace the existing test stuff with:

        <junit printsummary="true" showoutput="true" fork="yes" haltonfailure="$

        {test.failonerror}

        ">
        <classpath refid="test.classpath"/>
        <batchtest>
        <fileset dir="$

        {test.home}

        ">
        <include name="**/*TestCase.java"/>
        <include name="**/*Test.java"/>
        <include name="**/plugins/TestAll.java"/>
        <include name="**/TestFactoryCreate.java"/>
        </fileset>
        </batchtest>
        </junit>

        Which should we do?

        Show
        Henri Yandell added a comment - Either run 'maven ant', or replace the existing test stuff with: <junit printsummary="true" showoutput="true" fork="yes" haltonfailure="$ {test.failonerror} "> <classpath refid="test.classpath"/> <batchtest> <fileset dir="$ {test.home} "> <include name="**/*TestCase.java"/> <include name="**/*Test.java"/> <include name="**/plugins/TestAll.java"/> <include name="**/TestFactoryCreate.java"/> </fileset> </batchtest> </junit> Which should we do?
        Hide
        Henri Yandell added a comment -

        Emulating the changes in DBCP/Beanutils (I think it was those two); I've opted to update the build.xml and not to use 'maven ant'.

        I've also rewritten the build.properties.sample, using dbcp's as an example, so that running 'maven jar' puts the various required jar files into the location expected by the sample.

        Show
        Henri Yandell added a comment - Emulating the changes in DBCP/Beanutils (I think it was those two); I've opted to update the build.xml and not to use 'maven ant'. I've also rewritten the build.properties.sample, using dbcp's as an example, so that running 'maven jar' puts the various required jar files into the location expected by the sample.

          People

          • Assignee:
            Unassigned
            Reporter:
            Gail Badner
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development