The patch looks very good. There are however two issues that I would
like to have resolved before I commit the patch.
1) In DatabaseMetaData.getFunctionsX() you have this comment:
// Uncomment the following line when
DERBY-970 is committed
Since your patch is likely to get into trunk before my
patch, please copy checkServerJdbcVersionX() into your patch and
enable the check.
2) I liked the way you managed to test JDBC 4.0 functionality in a
test that doesn't require jdk 1.6 to compile and run, but I don't
see any good reason why the methods are invoked only when
jvm>=1.6. That is, I would have removed these lines from
// Make sure the method is available in the interface
With this change, getFunctions() will be tested in JVM 1.4/1.5 as
well, and you don't need to add separate canons for 1.6. Also note
that this change will require you to update
Upgrade_10_1_10_2.out. (Actually, in your current patch you should
have created a jdk16 version of Upgrade_10_1_10_2.out, but that
won't be necessary now.) I ran the upgrade test (jvm 1.5 and 1.6)
with this change, and the diff looked reasonable.