Derby
  1. Derby
  2. DERBY-873

OSGi bundle activator not JSR169 compliant

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 10.0.2.0
    • Fix Version/s: None
    • Component/s: Miscellaneous
    • Urgency:
      Normal

      Description

      EmbeddedActivator contains references to java.sql.DriverManager which is not included in JSR169.

      1. EmbeddedActivator.class
        1 kB
        Myrna van Lunteren
      2. DERBY-873_notforcommit.diff
        2 kB
        Myrna van Lunteren

        Activity

        Hide
        Knut Anders Hatlen added a comment -

        This bug doesn't affect trunk anymore, since support for JSR-169 has been removed. I don't think it's very likely that someone will step up to fix it on older branches, so I'm closing the issue as Won't Fix.

        Show
        Knut Anders Hatlen added a comment - This bug doesn't affect trunk anymore, since support for JSR-169 has been removed. I don't think it's very likely that someone will step up to fix it on older branches, so I'm closing the issue as Won't Fix.
        Hide
        Myrna van Lunteren added a comment -

        I'm removing the patch available flag; it doesn't appear anyone is available to try it out, and as Rick said, the patch probably needs some work at this point.

        Show
        Myrna van Lunteren added a comment - I'm removing the patch available flag; it doesn't appear anyone is available to try it out, and as Rick said, the patch probably needs some work at this point.
        Hide
        Rick Hillegas added a comment -

        Triaged for 10.5.3: assigned normal urgency and noted that a patch is attached (probably needs some work at this point)

        Show
        Rick Hillegas added a comment - Triaged for 10.5.3: assigned normal urgency and noted that a patch is attached (probably needs some work at this point)
        Hide
        Myrna van Lunteren added a comment -

        Based on Dan's suggestions I made some a stab. However, I don't have Knoplerfish or anything else installed, so this is a completely untested patch (except that it doesn't give build errors).

        I'll need to go through figuring out how to test this, but just in case someone who is all set up is interested in doing - for testing purposes only! - a jar -uvf I've included the class EmbeddedActovator.class - it'll need the directory structure created (org/apache/derby/osgi).

        Show
        Myrna van Lunteren added a comment - Based on Dan's suggestions I made some a stab. However, I don't have Knoplerfish or anything else installed, so this is a completely untested patch (except that it doesn't give build errors). I'll need to go through figuring out how to test this, but just in case someone who is all set up is interested in doing - for testing purposes only! - a jar -uvf I've included the class EmbeddedActovator.class - it'll need the directory structure created (org/apache/derby/osgi).
        Hide
        Myrna van Lunteren added a comment -

        In the thread:
        http://www.nabble.com/IBM-J9-Personal-Profile-1.1-%2B-OSGi-%2B-Derby-td19768406.html
        Dan gave some insightful comments, specifically:

        Really EmbeddedActivator should be booting the engine using internal methods similar to how EmbeddedSimpleDataSource.findSriver() does, and shutting down the engine using EmbeddedSimpleDataSource to get a connection and not DriverManager.

        Show
        Myrna van Lunteren added a comment - In the thread: http://www.nabble.com/IBM-J9-Personal-Profile-1.1-%2B-OSGi-%2B-Derby-td19768406.html Dan gave some insightful comments, specifically: Really EmbeddedActivator should be booting the engine using internal methods similar to how EmbeddedSimpleDataSource.findSriver() does, and shutting down the engine using EmbeddedSimpleDataSource to get a connection and not DriverManager.
        Hide
        Andrew McIntyre added a comment -

        Assigning to component Unknown for now. This should maybe be assigned to the Services component.

        Show
        Andrew McIntyre added a comment - Assigning to component Unknown for now. This should maybe be assigned to the Services component.

          People

          • Assignee:
            Unassigned
            Reporter:
            Byron K. Appelt
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development