[DERBY-6962] Forbid ALTER TABLE ... SET CYCLE on identity columns in pre-10.11 databases

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 10.14.1.0
• Fix Version/s: 10.14.1.0
• Component/s: SQL
• Urgency: Blocker
• Assignee: Richard N. Hillegas
• Reporter: Richard N. Hillegas
• Created: 16/Sep/17 15:51
• Updated: 17/Sep/17 15:31
• Resolved: 17/Sep/17 15:31

Description

The

ALTER TABLE ALTER COLUMN $columnName SET CYCLE

command does not raise an error even on identity columns in pre-10.12 databases. Those identity columns are not backed by sequence generators. Afterwards, the columns do not cycle, even though the ALTER TABLE command appeared to run successfully. This should be easy to fix. The parser just needs to forbid the ALTER TABLE...SET CYCLE command in pre-10.12 databases. The following scripts show this behavior:

-- run the following script with version 10.10.1.1:
connect 'jdbc:derby:db;create=true';

create table t1(a int generated always as identity (start with 2147483646), b int);
insert into t1(b) values (1);
insert into t1(b) values (2);
-- fails as expected
insert into t1(b) values (3);

select * from t1 order by b;

create table t2(a int generated always as identity (start with 2147483646), b int);

-- now run the following script with 10.14
connect 'jdbc:derby:db';

-- succeeds but should not
alter table t2 alter column a set cycle;

insert into t2(b) values (1);
insert into t2(b) values (2);
-- fails because the cycling behavior did not change
insert into t2(b) values (3);

select * from t2 order by b;

Issue Links

• blocks: DERBY-6904 Enhance ALTER TABLE to allow CYCLE option to be changed.