[DERBY-6823] Refactor uses of DB2_JCC_MAX_EXCEPTION_PARAM_LENGTH

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Component/s: Network Server, SQL
• Assignee: Abhinav Gupta
• Reporter: Bryan Pendleton
• Created: 04/Jul/15 19:00
• Updated: 09/Sep/16 09:54
• Resolved: 20/Aug/15 14:05

Description

There is some duplication of code, probably historic, which
leads to multiple definitions of the named constant
DB2_JCC_MAX_EXCEPTION_PARAM_LENGTH:

$ find . -name '*.java' -exec grep DB2_JCC_MAX_EXCEPTION_PARAM_LENGTH {} \; -print
return Limits.DB2_JCC_MAX_EXCEPTION_PARAM_LENGTH;
./java/drda/org/apache/derby/impl/drda/AppRequester.java
public static final int DB2_JCC_MAX_EXCEPTION_PARAM_LENGTH = 2400;
./java/engine/org/apache/derby/iapi/reference/Limits.java
Types.VARCHAR, Limits.DB2_JCC_MAX_EXCEPTION_PARAM_LENGTH),
./java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java

I suspect this code pre-dates the work to create the "shared" library
where code shared among all Derby jar packages can reside.

It seems like we should be able to refactor this code so that
there is only one instance of DB2_JCC_MAX_EXCEPTION_PARAM_LENGTH,
and it seems like the new MessageUtils class proposed by
DERBY-6801 would be a good place for that constant to live.