Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-6716

Minor fixes in SystemPrivilegesPermissionTest

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 10.12.1.1
    • 10.12.1.1
    • Test
    • None

    Description

      I noticed two typos in SystemPrivilegesPermissionTest that reduces the test coverage ever so slightly.

      1) assertEquivalentPermissions() checks if two permissions, p1 and p2, are equal. One of the checks is supposed to be that p1 implies p2 and p2 implies p1. Instead of checking that both holds, it checks that p1 implies p2 twice.

      2) testSystemPermission() does some work to reorder expected actions to match the canonical action order before calling assertEquals(). However, assertEquals() is only called if the actions didn't have to be reordered. The assert could have been called unconditionally.

      Attachments

        1. d6716-1a.diff
          2 kB
          Knut Anders Hatlen

        Activity

          People

            knutanders Knut Anders Hatlen
            knutanders Knut Anders Hatlen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: