Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-6634

Improve test coverage of SqlXmlUtil.java

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 10.11.1.1
    • Fix Version/s: 10.11.1.1
    • Component/s: Test
    • Labels:
      None

      Description

      The test coverage report for SqlXmlUtil indicates that we don't have tests for:

      • recompilation of XML queries used in triggers (the code looks dead, and can probably be removed)
      • serialization of sequences of atomic values returned by an XPath query (as far as I can see, we only support single atomic values and sequences of documents, so probably that's also code that can be removed, possibly replaced by an assert)
      • XMLEXISTS operations where the XPath query returns a scalar (after DERBY-6624, it will take the same code path as a query that returns a non-empty sequence, so it won't show up in the report anymore, but it's still useful to have a test case for it)
      • XMLQUERY operations where the XPath query returns a boolean (after DERBY-6624, the same code path will be taken for all data types, so it won't show up in the report anymore, but it's still useful to have a test case for it)

        Attachments

        1. d6634-3a-impossible-paths.diff
          7 kB
          Knut Anders Hatlen
        2. d6634-2a-more-tests.diff
          2 kB
          Knut Anders Hatlen
        3. d6634-1a-dead-code.diff
          2 kB
          Knut Anders Hatlen

          Issue Links

            Activity

              People

              • Assignee:
                knutanders Knut Anders Hatlen
                Reporter:
                knutanders Knut Anders Hatlen
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: