[DERBY-6400] harness.NetServer method waitFor() is not reflecting timeout values

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 10.10.2.0, 10.11.1.1
• Component/s: Test
• Assignee: Myrna van Lunteren
• Reporter: Myrna van Lunteren
• Created: 31/Oct/13 18:28
• Updated: 22/Oct/14 19:17
• Resolved: 12/Nov/13 21:44

Description

On a slow machine, derbynetclientmats was seen to fail (with no test pass, nor fail) with the following error:

org.apache.derby.drda.NetworkServerControl start
Attempt to shutdown framework: DerbyNetClient
Server Process did not complete in time. Destroying...
Server Process did not complete in time. Destroying...
Exception in thread "main" java.io.IOException: Interrupted system call
at java.io.BufferedInputStream.fill(BufferedInputStream.java:235)
at java.io.BufferedInputStream.read1(BufferedInputStream.java:275)
at java.io.BufferedInputStream.read(BufferedInputStream.java:334)
at org.apache.derbyTesting.functionTests.harness.BackgroundStreamSaver.run(BackgroundStreamSaver.java:51)
at java.lang.Thread.run(Thread.java:853)

It seems to me that the problem is here that in functionTests.harness.NetServer the waitFor() method has a hard value of 60 in it. Instead, this value should be configurable.
In functionTests.harness.RunTest the waitFor() method uses
TimedProcess tp = new TimedProcess(pr);
tp.waitFor(timeout*60);
It seems NetServer should also be able to check on the timeout value.