[DERBY-6352] Access denied ("java.lang.RuntimePermission" "modifyThread") highly intermittent, but e.g. in store.RecoveryAfterBackup test

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 10.9.2.2, 10.10.1.1
• Fix Version/s: 10.10.2.1, 10.11.1.1
• Component/s: Test
• Environment: IBM java 7 Derby version 10.10.1.2 - (1494414)
• Bug behavior facts: Regression Test Failure
• Assignee: Myrna van Lunteren
• Reporter: Katherine Marsden
• Created: 25/Sep/13 12:55
• Updated: 21/Jan/15 00:23
• Resolved: 30/Apr/14 21:05

Description

I got a report of the following intermittent (6/60) exception in store.RecoveryAfterBackupTest.
Exception in thread "main" java.security.AccessControlException: Access denied ("java.lang.RuntimePermission" "modifyThread")
at java.security.AccessController.throwACE(AccessController.java:100)
at java.security.AccessController.checkPermission(AccessController.java:174)
at java.lang.SecurityManager.checkPermission(SecurityManager.java:549)
at java.lang.SecurityManager.checkAccess(SecurityManager.java:676)
at java.lang.Thread.checkAccess(Thread.java:459)
at java.lang.Thread.interrupt(Thread.java:588)
at org.apache.derby.iapi.services.context.ContextService$1.run(Unknown Source)
at java.security.AccessController.doPrivileged(AccessController.java:274)
at org.apache.derby.iapi.services.context.ContextService.notifyAllActiveThreads(Unknown Source)
at org.apache.derby.impl.services.monitor.BaseMonitor.shutdown(Unknown Source)
at org.apache.derby.jdbc.InternalDriver.connect(Unknown Source)
at org.apache.derby.jdbc.Driver20.connect(Unknown Source)
at org.apache.derby.jdbc.AutoloadedDriver.connect(Unknown Source)
at java.sql.DriverManager.getConnection(DriverManager.java:571)
at java.sql.DriverManager.getConnection(DriverManager.java:233)
at org.apache.derbyTesting.functionTests.util.TestUtil.getConnection(TestUtil.java:836)
at org.apache.derbyTesting.functionTests.tests.store.RecoveryAfterBackup.main(RecoveryAfterBackup.java:82)

modifyThread is a necessary permission if interrupting a thread other than the current thread but is not in our policy file for derby.jar.

The relevant code in ContextService is:
for (ContextManager cm : allContexts) {

Thread active = cm.activeThread;

if (active == me)
continue;

if (active == null)
continue;

final Thread fActive = active;
if (cm.setInterrupted(c))
{
AccessController.doPrivileged(
new PrivilegedAction<Void>() {
public Void run()

{ fActive.interrupt(); return null; }

});
}

I am not sure why this has never come up before. Are we expecting in this context that fActive is the current thread?

Issue Links

• is duplicated by: DERBY-5812 test failure in org.apache.derbyTesting.functionTests.tests.multi.StressMultiTestjava.security.AccessControlException: Access denied (java.lang.RuntimePermission modifyThread)
• is related to: DERBY-5571 IndexStatisticsDaemonImpl.schedule should wrap Thread.setDaemon() in a privilege block
• is related to: DERBY-5812 test failure in org.apache.derbyTesting.functionTests.tests.multi.StressMultiTestjava.security.AccessControlException: Access denied (java.lang.RuntimePermission modifyThread)
• is related to: DERBY-6084 org.apache.derbyTesting.functionTests.tests.multi.StressMultiTestjava.security.AccessControlException: Access denied (java.lang.RuntimePermission modifyThread) cascades to 38 errors and 674 failures in nightly test run against ibm16
• is related to: DERBY-2816 'jdbcapi/secureUsers1.sql' failed with "..... The connection has been terminated." on shutdown