Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-6263

Make acceptChildren() overloads visit all clauses in QueryTreeNodes



    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • SQL
    • Normal
    • Seen in production


      The acceptChildren() overloads don't visit all of the clauses in an AST node. This is probably a mistake. However, fixing it will require a systematic analysis of the AST nodes and probably some changes to the Visitors. Some queries rely on the fact that certain Visitors will not be called on some AST nodes even though the Visitors are called on sister nodes in the same parent AST node.

      An example of this defect is the CursorNode. If you call treePrint() on a CursorNode, you will see information on ORDER BY, FETCH, and OFFSET clauses. However, these clauses are not visited by CursorNode.acceptChildren(). This looks like an omission. This defect was brought to our attention by this email thread: http://apache-database.10148.n7.nabble.com/Using-ASTParser-and-TreeWalker-for-parsing-SQL-query-td131219.html. You can see the difference in treePrint() and acceptChildren() behavior by running the following query through the ASTParser and TreePrinter tools attached to DERBY-3946:

      select tablename from sys.systables where 1=2 order by tablename;


        1. derby-6263-01-aa-visit-ignored-clauses.diff
          1 kB
          Richard N. Hillegas
        2. derby-6263-02-aa-ignored-clauses-in-SelectNode.diff
          2 kB
          Richard N. Hillegas
        3. derby-6263-03-aa-defensiveNullChecking-in-SelectNode.diff
          1.0 kB
          Richard N. Hillegas
        4. derby-6263-03-ab-defensiveNullChecking-in-SelectNode.diff
          2 kB
          Richard N. Hillegas

        Issue Links



              Unassigned Unassigned
              rhillegas Richard N. Hillegas
              0 Vote for this issue
              4 Start watching this issue