Derby
  1. Derby
  2. DERBY-6086

Factor out logic for creating custom connection in jdbcapi.StatementPoolingTest

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.10.1.1
    • Fix Version/s: 10.10.1.1
    • Component/s: Test
    • Labels:
      None

      Description

      There is quite a bit of common boilerplate code in jdbcapi.StatementPoolingTest related to getting a custom connection, or rather more than one logical connection from a single pooled (physical) connection.

      This could be factored out to make the test methods shorter, and to make the test methods more focused on whatever they're testing.

        Activity

        Hide
        Kristian Waagan added a comment -

        Attaching patch 1a.
        It pulls out the connection logic, and also fixes a number of spelling errors.

        Patch ready for review.

        Show
        Kristian Waagan added a comment - Attaching patch 1a. It pulls out the connection logic, and also fixes a number of spelling errors. Patch ready for review.
        Hide
        Dag H. Wanvik added a comment - - edited

        Looks like a good cleanup. +1 Nit: I'd drop this line (process comment, not code comment):

        + // Seven was used in the tests already, chose to use it as default.

        Show
        Dag H. Wanvik added a comment - - edited Looks like a good cleanup. +1 Nit: I'd drop this line (process comment, not code comment): + // Seven was used in the tests already, chose to use it as default.
        Hide
        Kristian Waagan added a comment -

        Thanks, Dag.

        I removed the comment in patch 1b. I added it in the first place to avoid questions about where I got the magical number 7 from.

        Committed patch 1b to trunk with revision 1448956.

        Show
        Kristian Waagan added a comment - Thanks, Dag. I removed the comment in patch 1b. I added it in the first place to avoid questions about where I got the magical number 7 from. Committed patch 1b to trunk with revision 1448956.
        Hide
        Knut Anders Hatlen added a comment -

        [bulk update] Close all resolved issues that haven't been updated for more than one year.

        Show
        Knut Anders Hatlen added a comment - [bulk update] Close all resolved issues that haven't been updated for more than one year.

          People

          • Assignee:
            Kristian Waagan
            Reporter:
            Kristian Waagan
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development