Derby
  1. Derby
  2. DERBY-6052

Text files under build/site do not have svn:eol-style=native

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.10.1.1
    • Component/s: Web Site
    • Labels:
      None

      Description

      Text files under build/site in the site repository, which points to [1], don't have the svn:eol-style=native set.

      This is a problem because:
      o it messes up your diffs on some platforms
      o building the site on some platforms ('forrest site') takes a long time (I observed 24 minutes on my machine)

      Regarding the second item above, 'svn st' told me there were 16121 changed files. I expected two files to have changed... Turns out Forrest will fix the line endings, and even when they are already correct all the checked in docs files seem to be scanned. A second run took around 5 minutes on my Windows machine.

      While 5 minutes is better than 24 minutes, it's still significant. I've heard others can build the site in 30 seconds, but I don't know if the fix crlf target isn't run on those platforms,or if the file system in question is a lot faster.

      As a reminder, people should consider downloading this file [2] to configure Subversion wrt EOL style.

      [1] https://svn.apache.org/repos/infra/websites/production/db/content/derby/
      [2] http://apache.org/dev/svn-eol-style.txt

        Activity

        Hide
        Knut Anders Hatlen added a comment -

        I just ran "forrest site" three times on a Debian box. The first run took 62 seconds. The next two runs took only 26 seconds each. I don't know how to tell whether or not it tried to fix crlf, though.

        In any case, +1 to setting svn:eol-style=native on the html files under build/site.

        Show
        Knut Anders Hatlen added a comment - I just ran "forrest site" three times on a Debian box. The first run took 62 seconds. The next two runs took only 26 seconds each. I don't know how to tell whether or not it tried to fix crlf, though. In any case, +1 to setting svn:eol-style=native on the html files under build/site.
        Hide
        Knut Anders Hatlen added a comment -

        How odd. I ran "forrest site" again three times after "svn up" to get the svn:eol-style updates. Now it took 2 min 13 sec, 2 min 9 sec and 2 min 9 sec. So it had the opposite effect on the performance in my environment. It's not too bad, though.

        Show
        Knut Anders Hatlen added a comment - How odd. I ran "forrest site" again three times after "svn up" to get the svn:eol-style updates. Now it took 2 min 13 sec, 2 min 9 sec and 2 min 9 sec. So it had the opposite effect on the performance in my environment. It's not too bad, though.
        Hide
        Myrna van Lunteren added a comment -

        This is a huge improvement from last time I ran forrest site on my windows 7 laptop, only diffs to be reverted now left are a number of png files, the changed japanese characters in build/site/manuals/index.html, some .css files that have a diff like this:
        -}
        \ No newline at end of file
        +}
        and a few html files have diffs replacing a & with &amp. It took 2 min 57 seconds. Thx!

        Show
        Myrna van Lunteren added a comment - This is a huge improvement from last time I ran forrest site on my windows 7 laptop, only diffs to be reverted now left are a number of png files, the changed japanese characters in build/site/manuals/index.html, some .css files that have a diff like this: -} \ No newline at end of file +} and a few html files have diffs replacing a & with &amp. It took 2 min 57 seconds. Thx!
        Hide
        Kristian Waagan added a comment -

        The changes went in with revision 847783.

        Knut, do you see the modified PNGs on Linux? I'm seeing them on Solaris and Windows.

        Myrna, some comments to what you're seeing:
        o the PNGs seem to be a problem for several platforms. Tracked by [1], I think.
        o the Japanse characters problem can be fixed by using an appropriate locale / encoding, and is not a problem with the Windows platform itself.
        o the CSS diffs issue is another problem with developers on multiple platforms. We can get rid of it on one platform, but then it pops up on another...

        Regarding the CSS problem, I don't know what tool/technology is used to write them to disk, but I'd guess they're constructed by Cocoon somehow.

        Another tip: Be careful with "forrest clean"... You'd be better off reverting build/site and manually deleting the other directories within build/. If you run the target you'll have to check out build/site again, and that takes a while. This brings me to a discussion we should have at some point, which is whether we want to keep hosting really old docs in the current representation indefinitely.

        [1] https://issues.apache.org/jira/browse/FOR-915

        Show
        Kristian Waagan added a comment - The changes went in with revision 847783. Knut, do you see the modified PNGs on Linux? I'm seeing them on Solaris and Windows. Myrna, some comments to what you're seeing: o the PNGs seem to be a problem for several platforms. Tracked by [1] , I think. o the Japanse characters problem can be fixed by using an appropriate locale / encoding, and is not a problem with the Windows platform itself. o the CSS diffs issue is another problem with developers on multiple platforms. We can get rid of it on one platform, but then it pops up on another... Regarding the CSS problem, I don't know what tool/technology is used to write them to disk, but I'd guess they're constructed by Cocoon somehow. Another tip: Be careful with "forrest clean"... You'd be better off reverting build/site and manually deleting the other directories within build/. If you run the target you'll have to check out build/site again, and that takes a while. This brings me to a discussion we should have at some point, which is whether we want to keep hosting really old docs in the current representation indefinitely. [1] https://issues.apache.org/jira/browse/FOR-915
        Hide
        Kristian Waagan added a comment -

        > o the Japanse characters problem can be fixed by using an appropriate locale / encoding, and is not a problem with the Windows platform itself.

        To be more specific, you normally only need to add "-Dfile.encoding=UTF8" to your ANT_OPTS environment variable. If that doesn't work, maybe also executing "chcp 65001" in your cmd shell does the trick.
        Setting file.encoding is generally frowned upon and not guaranteed to work, so let's know if it doesn't work with your JVM.

        The well known garbling of the Japanese characters in manuals/index.html is not caused by Forrest when generating the content, but rather by some postprocessing step (possibly the fixcrlf ant target).
        I considered documenting the above on the web site, but if we decide to get rid of the outdated Japanese manuals the extra configuration step won't be required any more.

        Resolving issue.

        Show
        Kristian Waagan added a comment - > o the Japanse characters problem can be fixed by using an appropriate locale / encoding, and is not a problem with the Windows platform itself. To be more specific, you normally only need to add "-Dfile.encoding=UTF8" to your ANT_OPTS environment variable. If that doesn't work, maybe also executing "chcp 65001" in your cmd shell does the trick. Setting file.encoding is generally frowned upon and not guaranteed to work, so let's know if it doesn't work with your JVM. The well known garbling of the Japanese characters in manuals/index.html is not caused by Forrest when generating the content, but rather by some postprocessing step (possibly the fixcrlf ant target). I considered documenting the above on the web site, but if we decide to get rid of the outdated Japanese manuals the extra configuration step won't be required any more. Resolving issue.

          People

          • Assignee:
            Kristian Waagan
            Reporter:
            Kristian Waagan
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development