Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-5992

Use BaseTestCase.execJavaCmd() to start process from NetworkServerTestSetup

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 10.10.1.1
    • Fix Version/s: 10.10.1.1
    • Component/s: Test
    • Labels:
      None

      Description

      NetworkServerTestSetup invokes Runtime.exec(String[]) manually when it needs to start a sub-process. It should use BaseTestCase.execJavaCmd(). In addition to reducing the amount of code, it would make the server processes pick up the flags they need to work well with EMMA and JaCoCo.

      1. d5992-1a.diff
        4 kB
        Knut Anders Hatlen

        Activity

        Hide
        knutanders Knut Anders Hatlen added a comment -

        I've started a test run on the attached d5992-1a.diff patch, which makes NetworkServerTestSetup use the helper method to start a sub-process.

        Show
        knutanders Knut Anders Hatlen added a comment - I've started a test run on the attached d5992-1a.diff patch, which makes NetworkServerTestSetup use the helper method to start a sub-process.
        Hide
        knutanders Knut Anders Hatlen added a comment -

        All tests passed with the patch. Committed revision 1409113.

        Show
        knutanders Knut Anders Hatlen added a comment - All tests passed with the patch. Committed revision 1409113.

          People

          • Assignee:
            knutanders Knut Anders Hatlen
            Reporter:
            knutanders Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development