Derby
  1. Derby
  2. DERBY-5971

Improve test coverage for SQLBoolean class

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.10.1.1
    • Fix Version/s: 10.10.1.1
    • Component/s: Test
    • Labels:
      None

      Description

      When looking at a test coverage report, I noticed that these methods in the SQLBoolean class are not tested:

      • falseTruthValue
      • trueTruthValue
      • greaterOrEquals
      • greaterThan
      • lessOrEquals
      • lessThan
      • is
      • isNot
      • readExternal
      • hashCode

      falseTruthValue() and trueTruthValue() are never called anywhere in the code and could be removed.

      is() and isNot() also have no callers. However, they implement the boolean IS operator which is part of the SQL standard, so it might make more sense to file a JIRA to add the syntax to the grammar rather than removing the methods.

      1. d5971-1a-unused-and-binary-operators.diff
        8 kB
        Knut Anders Hatlen
      2. d5971-2a-hashCode.diff
        1 kB
        Knut Anders Hatlen

        Issue Links

          Activity

            People

            • Assignee:
              Knut Anders Hatlen
              Reporter:
              Knut Anders Hatlen
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development