[DERBY-5971] Improve test coverage for SQLBoolean class

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 10.10.1.1
• Fix Version/s: 10.10.1.1
• Component/s: Test
• Assignee: Knut Anders Hatlen
• Reporter: Knut Anders Hatlen
• Created: 31/Oct/12 12:12
• Updated: 17/Jun/13 09:27
• Resolved: 06/Nov/12 13:24

Description

When looking at a test coverage report, I noticed that these methods in the SQLBoolean class are not tested:

• falseTruthValue
• trueTruthValue
• greaterOrEquals
• greaterThan
• lessOrEquals
• lessThan
• is
• isNot
• readExternal
• hashCode

falseTruthValue() and trueTruthValue() are never called anywhere in the code and could be removed.

is() and isNot() also have no callers. However, they implement the boolean IS operator which is part of the SQL standard, so it might make more sense to file a JIRA to add the syntax to the grammar rather than removing the methods.

Issue Links

• relates to: DERBY-5973 Add syntax for boolean IS operator
• relates to: DERBY-2920 Share code between readExternal() and readExternalFromArray()