Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-5883

Simplify JSR-169 implementation class tree

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 10.10.1.1
    • Fix Version/s: 10.10.1.1
    • Component/s: JDBC
    • Labels:
      None

      Description

      The JSR-169 interface is a subset of JDBC 3.0, but still the JDBC 3.0 implementation classes do not extend the JSR-169 implementation classes. Instead, the JSR-169 and JDBC 3.0 implementation classes extend a common base class. The reason for this structure, is that the JSR-169 compile targets used to be optional, so the JDBC 3.0 classes could not depend on them.

      For example, the class javadoc comment for EmbedResultSet169 says:

      • ResultSet implementation for JSR169.
      • Adds no functionality to its (abstract) parent class.
      • If Derby could be compiled against JSR169 that the parent
      • class could be the concrete class for the environment.
      • Just like for the JDBC 2.0 specific classes.
      • Until that is possible (ie. easily downloadable J2ME/CDC/Foundation/JSR169
      • jar files, this class is required and is only compiled by an optional target.

      Since the JSR-169 code is no longer optional, we should do as the comment suggests, and use the base class directly instead. This would allow us to simplify the class tree.

        Attachments

        1. d5883-1a.diff
          13 kB
          Knut Anders Hatlen

          Activity

            People

            • Assignee:
              knutanders Knut Anders Hatlen
              Reporter:
              knutanders Knut Anders Hatlen
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: