Derby
  1. Derby
  2. DERBY-5874

Remove JDBC 3 constants from client.am.Statement

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 10.10.1.1
    • Fix Version/s: 10.10.1.1
    • Component/s: JDBC
    • Labels:
      None

      Description

      org.apache.derby.client.am.Statement defines three constants, CLOSE_CURRENT_RESULT, KEEP_CURRENT_RESULT and CLOSE_ALL_RESULTS, that are also defined in java.sql.Statement. Since client.am.Statement implements java.sql.Statement, we could remove those constants and let it inherit them instead. The only reason why these constants are defined in client.am.Statement, is to make the client compile on JDKs predating JDBC 3 (that is, Java 1.3 and earlier). Since we don't support those JDKs anymore, the constants can be removed now.

      1. d5874.diff
        2 kB
        Knut Anders Hatlen

        Activity

        Knut Anders Hatlen created issue -
        Hide
        Knut Anders Hatlen added a comment -

        The attached patch removes the three constants. All the regression tests passed.

        Show
        Knut Anders Hatlen added a comment - The attached patch removes the three constants. All the regression tests passed.
        Knut Anders Hatlen made changes -
        Field Original Value New Value
        Attachment d5874.diff [ 12537654 ]
        Knut Anders Hatlen made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Knut Anders Hatlen made changes -
        Issue & fix info Patch Available [ 10102 ]
        Hide
        Knut Anders Hatlen added a comment -

        Committed revision 1365173.

        Show
        Knut Anders Hatlen added a comment - Committed revision 1365173.
        Knut Anders Hatlen made changes -
        Status In Progress [ 3 ] Closed [ 6 ]
        Issue & fix info Patch Available [ 10102 ]
        Fix Version/s 10.10.0.0 [ 12321550 ]
        Resolution Fixed [ 1 ]
        Gavin made changes -
        Workflow jira [ 12717655 ] Default workflow, editable Closed status [ 12796980 ]

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development