Derby
  1. Derby
  2. DERBY-5860

Remove unused methods in DDMReader and DDMWriter

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.10.1.1
    • Fix Version/s: 10.10.1.1
    • Component/s: Network Server
    • Labels:
      None

      Description

      Many of the methods in DDMReader and DDMWriter are not used anymore. Those methods could be removed.

      1. d5860-1a.diff
        7 kB
        Knut Anders Hatlen

        Activity

        Hide
        Knut Anders Hatlen added a comment -

        Committed revision 1362837.

        Show
        Knut Anders Hatlen added a comment - Committed revision 1362837.
        Hide
        Knut Anders Hatlen added a comment -

        The attached patch removes the unused methods.

        DDMReader:

        • getCurrentCcsidManager()
        • getExtData(boolean)
        • readBoolean()
        • readStringData()
        • toDebugString(String)

        DDMWriter:

        • startDdm(int, int)
        • writeScalarBytes(int, byte[], int)
        • writeScalarPaddedString (String, int)
        • writeScalarBytes (int, byte[], int, int)
        • zeroPadString(String, int)
        • toDebugString(String)

        The toDebugString(String) methods could perhaps be kept in case someone needs them when debugging. However, they only return the buffer size, so they are not very useful in their current state.

        All the regression tests ran cleanly with the patch.

        Show
        Knut Anders Hatlen added a comment - The attached patch removes the unused methods. DDMReader: getCurrentCcsidManager() getExtData(boolean) readBoolean() readStringData() toDebugString(String) DDMWriter: startDdm(int, int) writeScalarBytes(int, byte[], int) writeScalarPaddedString (String, int) writeScalarBytes (int, byte[], int, int) zeroPadString(String, int) toDebugString(String) The toDebugString(String) methods could perhaps be kept in case someone needs them when debugging. However, they only return the buffer size, so they are not very useful in their current state. All the regression tests ran cleanly with the patch.

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development