Derby
  1. Derby
  2. DERBY-5834

Remove unused methods in NetPreparedStatement class

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.10.1.1
    • Component/s: Network Client
    • Labels:
      None

      Description

      The following two methods in NetPreparedStatement class are never used. It might be possible to remove them.

      • resetNetPreparedStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section)
      • resetNetPreparedStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section, ColumnMetaData parameterMetaData, ColumnMetaData resultSetMetaData)
      1. derby-5834.patch
        2 kB
        Mohamed Nufail

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        5d 22h 6m 1 Bryan Pendleton 03/Jul/12 06:04
        Resolved Resolved Closed Closed
        500d 3h 10m 1 Knut Anders Hatlen 15/Nov/13 08:15
        Knut Anders Hatlen made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Knut Anders Hatlen added a comment -

        [bulk update: close all resolved issues that haven't had any activity the last year]

        Show
        Knut Anders Hatlen added a comment - [bulk update: close all resolved issues that haven't had any activity the last year]
        Gavin made changes -
        Workflow jira [ 12708751 ] Default workflow, editable Closed status [ 12797108 ]
        Bryan Pendleton made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Mohamed Nufail [ nufail ]
        Fix Version/s 10.10.0.0 [ 12321550 ]
        Resolution Fixed [ 1 ]
        Hide
        Bryan Pendleton added a comment -

        This patch looks great to me. I agree with the observation that
        these overloads of the resetNetPreparedStatement method are
        unused, and should be removed.

        My builds and tests were successful, and I've committed this
        patch to the trunk as revision 1356573.

        Show
        Bryan Pendleton added a comment - This patch looks great to me. I agree with the observation that these overloads of the resetNetPreparedStatement method are unused, and should be removed. My builds and tests were successful, and I've committed this patch to the trunk as revision 1356573.
        Mohamed Nufail made changes -
        Attachment derby-5834.patch [ 12533610 ]
        Hide
        Mohamed Nufail added a comment -

        derby-5834.patch removes these two methods

        Show
        Mohamed Nufail added a comment - derby-5834.patch removes these two methods
        Mohamed Nufail made changes -
        Field Original Value New Value
        Priority Major [ 3 ] Minor [ 4 ]
        Mohamed Nufail created issue -

          People

          • Assignee:
            Mohamed Nufail
            Reporter:
            Mohamed Nufail
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development