Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-5834

Remove unused methods in NetPreparedStatement class

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.10.1.1
    • Component/s: Network Client
    • Labels:
      None

      Description

      The following two methods in NetPreparedStatement class are never used. It might be possible to remove them.

      • resetNetPreparedStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section)
      • resetNetPreparedStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section, ColumnMetaData parameterMetaData, ColumnMetaData resultSetMetaData)
      1. derby-5834.patch
        2 kB
        Mohamed Nufail

        Activity

        Hide
        nufail Mohamed Nufail added a comment -

        derby-5834.patch removes these two methods

        Show
        nufail Mohamed Nufail added a comment - derby-5834.patch removes these two methods
        Hide
        bryanpendleton Bryan Pendleton added a comment -

        This patch looks great to me. I agree with the observation that
        these overloads of the resetNetPreparedStatement method are
        unused, and should be removed.

        My builds and tests were successful, and I've committed this
        patch to the trunk as revision 1356573.

        Show
        bryanpendleton Bryan Pendleton added a comment - This patch looks great to me. I agree with the observation that these overloads of the resetNetPreparedStatement method are unused, and should be removed. My builds and tests were successful, and I've committed this patch to the trunk as revision 1356573.
        Hide
        knutanders Knut Anders Hatlen added a comment -

        [bulk update: close all resolved issues that haven't had any activity the last year]

        Show
        knutanders Knut Anders Hatlen added a comment - [bulk update: close all resolved issues that haven't had any activity the last year]

          People

          • Assignee:
            nufail Mohamed Nufail
            Reporter:
            nufail Mohamed Nufail
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development