Derby
  1. Derby
  2. DERBY-5833

Remove unused methods in NetCallableStatement class

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.10.1.1
    • Component/s: Network Client
    • Labels:
      None

      Description

      The following methods in NetCallableStatement class seem to be dead code. It might be possible to remove them.

      • resetNetCallableStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section)
      • resetNetCallableStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section, ColumnMetaData parameterMetaData, ColumnMetaData resultSetMetaData)
      1. derby-5833.patch
        1 kB
        Mohamed Nufail

        Activity

        Hide
        Mohamed Nufail added a comment -

        Attached file derby-5833.patch removes these two methods.

        Show
        Mohamed Nufail added a comment - Attached file derby-5833.patch removes these two methods.
        Hide
        Bryan Pendleton added a comment -

        I checked the svn history for NetCallableStatement.java and
        this code was introduced as part of the original contribution
        to Derby, and has not been modified since.

        I searched the codebase and agree that these two methods
        are unused.

        Of the two remaining overloads of resetNetCallableStatement,
        it seems that the 3-argument version is called only internally,
        by the 6-argument version, so it should be possible, if we so
        chose, to make the 3-argument version private, as part of some
        future change.

        My builds and tests were successful, so I committed the
        patch to the trunk as revision 1356066.

        Show
        Bryan Pendleton added a comment - I checked the svn history for NetCallableStatement.java and this code was introduced as part of the original contribution to Derby, and has not been modified since. I searched the codebase and agree that these two methods are unused. Of the two remaining overloads of resetNetCallableStatement, it seems that the 3-argument version is called only internally, by the 6-argument version, so it should be possible, if we so chose, to make the 3-argument version private, as part of some future change. My builds and tests were successful, so I committed the patch to the trunk as revision 1356066.

          People

          • Assignee:
            Mohamed Nufail
            Reporter:
            Mohamed Nufail
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development