Derby
  1. Derby
  2. DERBY-5828

Remove unused methods in NetPackageReply class

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.10.1.1
    • Component/s: Network Client
    • Labels:
      None

      Description

      parsePKGNAMCT(boolean skip) method in NetPackageReply class seems to be not used at all. It may be possible to remove this method if it's not required.

      1. DERBY-5828.patch
        1 kB
        Mohamed Nufail

        Activity

        Mohamed Nufail created issue -
        Hide
        Mohamed Nufail added a comment -

        DERBY-5828.patch removes the parsePKGNAMCT(boolean skip) method.

        Show
        Mohamed Nufail added a comment - DERBY-5828 .patch removes the parsePKGNAMCT(boolean skip) method.
        Mohamed Nufail made changes -
        Field Original Value New Value
        Attachment DERBY-5828.patch [ 12533001 ]
        Hide
        Bryan Pendleton added a comment -

        I concur with this analysis. I looked through svn history,
        searched the code base, and agree that the method should
        be removed.

        My builds and tests were clean, and I've committed the
        patch to the trunk as revision 1356568.

        Thanks for the contribution to Derby!

        Show
        Bryan Pendleton added a comment - I concur with this analysis. I looked through svn history, searched the code base, and agree that the method should be removed. My builds and tests were clean, and I've committed the patch to the trunk as revision 1356568. Thanks for the contribution to Derby!
        Bryan Pendleton made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Mohamed Nufail [ nufail ]
        Fix Version/s 10.10.0.0 [ 12321550 ]
        Resolution Fixed [ 1 ]
        Gavin made changes -
        Workflow jira [ 12708251 ] Default workflow, editable Closed status [ 12797107 ]
        Hide
        Knut Anders Hatlen added a comment -

        [bulk update: close all resolved issues that haven't had any activity the last year]

        Show
        Knut Anders Hatlen added a comment - [bulk update: close all resolved issues that haven't had any activity the last year]
        Knut Anders Hatlen made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        10d 21h 51m 1 Bryan Pendleton 03/Jul/12 05:06
        Resolved Resolved Closed Closed
        500d 4h 9m 1 Knut Anders Hatlen 15/Nov/13 08:15

          People

          • Assignee:
            Mohamed Nufail
            Reporter:
            Mohamed Nufail
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development