Derby
  1. Derby
  2. DERBY-5783

Remove duplicated code for starting remote processes in replication tests

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.10.1.1
    • Fix Version/s: 10.10.1.1
    • Component/s: Test
    • Labels:
      None

      Description

      ReplicationRun has two copies of each of the methods runUserCommand(), runUserCommandRemotely() and processOutput(). One variant takes an id parameter (used only in debug output), and one doesn't. It would be sufficient to have one copy of each of these methods.

      1. d5783-1a.diff
        5 kB
        Knut Anders Hatlen

        Issue Links

          Activity

          Knut Anders Hatlen created issue -
          Knut Anders Hatlen made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          Knut Anders Hatlen added a comment -

          The attached patch replaces two calls to the three-arg runUserCommandRemotely() method with calls to the four-arg variant of the method, and removes three methods that become unused because of the change.

          Replication tests passed with the patch.

          Show
          Knut Anders Hatlen added a comment - The attached patch replaces two calls to the three-arg runUserCommandRemotely() method with calls to the four-arg variant of the method, and removes three methods that become unused because of the change. Replication tests passed with the patch.
          Knut Anders Hatlen made changes -
          Attachment d5783-1a.diff [ 12529705 ]
          Knut Anders Hatlen made changes -
          Issue & fix info Patch Available [ 10102 ]
          Knut Anders Hatlen made changes -
          Link This issue is related to DERBY-5791 [ DERBY-5791 ]
          Hide
          Dag H. Wanvik added a comment -

          Looks like a safe and good cleanup. +1

          Show
          Dag H. Wanvik added a comment - Looks like a safe and good cleanup. +1
          Hide
          Knut Anders Hatlen added a comment -

          Thanks, Dag. Committed r1344190.

          Show
          Knut Anders Hatlen added a comment - Thanks, Dag. Committed r1344190.
          Knut Anders Hatlen made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Issue & fix info Patch Available [ 10102 ]
          Fix Version/s 10.10.0.0 [ 12321550 ]
          Resolution Fixed [ 1 ]
          Knut Anders Hatlen made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Workflow jira [ 12670200 ] Default workflow, editable Closed status [ 12797076 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open In Progress In Progress
          1m 36s 1 Knut Anders Hatlen 25/May/12 12:54
          In Progress In Progress Resolved Resolved
          4d 23h 3m 1 Knut Anders Hatlen 30/May/12 11:58
          Resolved Resolved Closed Closed
          55d 6h 32m 1 Knut Anders Hatlen 24/Jul/12 18:31

            People

            • Assignee:
              Knut Anders Hatlen
              Reporter:
              Knut Anders Hatlen
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development