Derby
  1. Derby
  2. DERBY-5742

Native user authentication: improve wording of error message

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.9.1.0
    • Fix Version/s: 10.9.1.0
    • Component/s: Services
    • Labels:
      None
    • Issue & fix info:
      Patch Available
    • Bug behavior facts:
      Security

      Description

      This error message no longer has a correct string: XCY05

      (quote from English locale):

      Invalid setting of the derby.authentication.provider property. This property cannot be set to NATIVE::LOCAL unless credentials for the database owner have been stored in the database using the SYSCS_UTIL.SYSCS_CREATE_USER procedure.

      This property should no longer ever need to be set to NATIVE::LOCAL: it is done automatically when the first user is created via SYSCS_UTIL.SYSCS_CREATE_USER.
      The wording should be adjusted. Note: Now, the property should never be set manually for native authentication via SYSCS_UTIL.SYSCS_SET_DATABASE_PROPERTY, this is only meaningful for LOCAL credentials db, but this is done automatically since version 7 of the spec.

      1. repro2.sh
        0.5 kB
        Dag H. Wanvik
      2. derby-5742-01-aa-rewordMessage.diff
        0.8 kB
        Rick Hillegas
      3. derby-5742-01-ab-rewordMessage.diff
        0.8 kB
        Rick Hillegas

        Issue Links

          Activity

          Hide
          Dag H. Wanvik added a comment -

          Both XCY05.S.1 and XCY05.S.3 need adjustment. Perhaps also XCY05.S.2: "has already been set" should perhaps be "has already been implicitly/automatically set" ..?

          Show
          Dag H. Wanvik added a comment - Both XCY05.S.1 and XCY05.S.3 need adjustment. Perhaps also XCY05.S.2: "has already been set" should perhaps be "has already been implicitly/automatically set" ..?
          Hide
          Rick Hillegas added a comment -

          Attaching derby-5742-01-aa-rewordMessage.diff. This changes the wording for the error condition. Here is the new wording:

          "Invalid setting of the derby.authentication.provider property. To enable NATIVE authentication, please use the SYSCS_UTIL.SYSCS_CREATE_USER procedure to store credentials for the database owner."

          Show
          Rick Hillegas added a comment - Attaching derby-5742-01-aa-rewordMessage.diff. This changes the wording for the error condition. Here is the new wording: "Invalid setting of the derby.authentication.provider property. To enable NATIVE authentication, please use the SYSCS_UTIL.SYSCS_CREATE_USER procedure to store credentials for the database owner."
          Hide
          Rick Hillegas added a comment -

          The other two error messages look ok to me. XCY05.S.1 would be thrown if you tried to set derby.authentication.provider=NATIVE::GLOBAL. XCY05.S.2 would be thrown if you tried to set derby.authentication.provider=LDAP after NATIVE authentication had been enabled. Thanks.

          Show
          Rick Hillegas added a comment - The other two error messages look ok to me. XCY05.S.1 would be thrown if you tried to set derby.authentication.provider=NATIVE::GLOBAL. XCY05.S.2 would be thrown if you tried to set derby.authentication.provider=LDAP after NATIVE authentication had been enabled. Thanks.
          Hide
          Kim Haase added a comment -

          You could drop "please" – we avoid it in documentation. We're polite enough.

          Show
          Kim Haase added a comment - You could drop "please" – we avoid it in documentation. We're polite enough.
          Hide
          Rick Hillegas added a comment -

          Thanks, Kim. Attaching derby-5742-01-ab-rewordMessage.diff, which removes the extra courtesy. Committed at subversion revision 1333915.

          Show
          Rick Hillegas added a comment - Thanks, Kim. Attaching derby-5742-01-ab-rewordMessage.diff, which removes the extra courtesy. Committed at subversion revision 1333915.
          Hide
          Dag H. Wanvik added a comment -

          Thanks, Rick! The change looks for good for XXCY05.S.3.

          > XCY05.S.1: "Invalid setting of the derby.authentication.provider property. NATIVE::LOCAL is the only NATIVE value accepted by derby.authentication.provider."

          Well, we never do accept "NATIVE::LOCAL" as an explicitly set value anymore, do we? Quoting from the spec 7.0:
          "NATIVE::LOCAL - This value is never explicitly set by an application. It is ignored if it is set via JVM properties or via derby.properties."

          So, I still think the wording is misleading.

          Show
          Dag H. Wanvik added a comment - Thanks, Rick! The change looks for good for XXCY05.S.3. > XCY05.S.1: "Invalid setting of the derby.authentication.provider property. NATIVE::LOCAL is the only NATIVE value accepted by derby.authentication.provider." Well, we never do accept "NATIVE::LOCAL" as an explicitly set value anymore, do we? Quoting from the spec 7.0: "NATIVE::LOCAL - This value is never explicitly set by an application. It is ignored if it is set via JVM properties or via derby.properties." So, I still think the wording is misleading.
          Hide
          Rick Hillegas added a comment -

          Hi Dag,

          How about this text for XCY05.S.1: "Invalid setting of the derby.authentication.provider property."

          Show
          Rick Hillegas added a comment - Hi Dag, How about this text for XCY05.S.1: "Invalid setting of the derby.authentication.provider property."
          Hide
          Dag H. Wanvik added a comment -

          Thanks, Rick! That's fine, I think. +1

          Show
          Dag H. Wanvik added a comment - Thanks, Rick! That's fine, I think. +1

            People

            • Assignee:
              Rick Hillegas
              Reporter:
              Dag H. Wanvik
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development