Derby
  1. Derby
  2. DERBY-5740

Remove unsued code in AlterTableConstantaction.columnDroppedAndTriggerDependencies

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 10.9.1.0
    • Fix Version/s: 10.10.1.1
    • Component/s: SQL
    • Urgency:
      Normal

      Description

      The following code is executed, but the results are not used:
      CollectNodesVisitor visitor = new CollectNodesVisitor(ColumnReference.class);
      stmtnode.accept(visitor);
      Vector refs = visitor.getList(); <--- never used

      I plan to remove the code, but just want to record it here in case there are side-effects by using the visitor.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        150d 20h 44m 1 Kristian Waagan 01/Oct/12 10:16
        Gavin made changes -
        Workflow jira [ 12665260 ] Default workflow, editable Closed status [ 12796913 ]
        Kristian Waagan made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Issue & fix info Patch Available [ 10102 ]
        Assignee Kristian Waagan [ kristwaa ]
        Fix Version/s 10.10.0.0 [ 12321550 ]
        Resolution Fixed [ 1 ]
        Hide
        Kristian Waagan added a comment -

        Committed to trunk with revision 1392243.
        Closing issue.

        Show
        Kristian Waagan added a comment - Committed to trunk with revision 1392243. Closing issue.
        Mamta A. Satoor made changes -
        Labels derby_triage10_10
        Urgency Normal [ 10052 ]
        Kristian Waagan made changes -
        Field Original Value New Value
        Attachment derby-5740-1a-code_removal.diff [ 12525437 ]
        Hide
        Kristian Waagan added a comment -

        Attaching patch 1a.

        Both derbyAll and suites.All passed with the patch, which suggests this is indeed unnecessary code and can be removed.

        Patch ready for review.

        Show
        Kristian Waagan added a comment - Attaching patch 1a. Both derbyAll and suites.All passed with the patch, which suggests this is indeed unnecessary code and can be removed. Patch ready for review.
        Kristian Waagan created issue -

          People

          • Assignee:
            Kristian Waagan
            Reporter:
            Kristian Waagan
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development