Derby
  1. Derby
  2. DERBY-5740

Remove unsued code in AlterTableConstantaction.columnDroppedAndTriggerDependencies

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 10.9.1.0
    • Fix Version/s: 10.10.1.1
    • Component/s: SQL
    • Urgency:
      Normal

      Description

      The following code is executed, but the results are not used:
      CollectNodesVisitor visitor = new CollectNodesVisitor(ColumnReference.class);
      stmtnode.accept(visitor);
      Vector refs = visitor.getList(); <--- never used

      I plan to remove the code, but just want to record it here in case there are side-effects by using the visitor.

        Activity

        Hide
        Kristian Waagan added a comment -

        Attaching patch 1a.

        Both derbyAll and suites.All passed with the patch, which suggests this is indeed unnecessary code and can be removed.

        Patch ready for review.

        Show
        Kristian Waagan added a comment - Attaching patch 1a. Both derbyAll and suites.All passed with the patch, which suggests this is indeed unnecessary code and can be removed. Patch ready for review.
        Hide
        Kristian Waagan added a comment -

        Committed to trunk with revision 1392243.
        Closing issue.

        Show
        Kristian Waagan added a comment - Committed to trunk with revision 1392243. Closing issue.

          People

          • Assignee:
            Kristian Waagan
            Reporter:
            Kristian Waagan
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development