Derby
  1. Derby
  2. DERBY-5354

Remove unnecessary dita.regex build target

    Details

      Description

      The dita.regex build target changes some of DITA's XSL files to look for .dita files instead of .xml files. But DITA already has a switch to change the file extension, namely the property dita.extname, and we set that property in docs.properties, so it shouldn't be necessary to change the DITA source files for this.

      (In newer versions of DITA than the one we're using, the dita.extname has been deprecated, and it's my understanding that both .xml and .dita are handled automatically now.)

      1. d5354.diff
        2 kB
        Knut Anders Hatlen

        Issue Links

          Activity

          Knut Anders Hatlen created issue -
          Knut Anders Hatlen made changes -
          Field Original Value New Value
          Link This issue is related to DERBY-5349 [ DERBY-5349 ]
          Knut Anders Hatlen made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          Knut Anders Hatlen added a comment -

          Attaching a patch that removes the dita.regex target (and also the related check.regex.done target) from build.xml, and reverts the unneeded customization in two of DITA's XSL files that we have checked in under lib.

          The docs are still built just fine in my environment with this change (tested with the getting started guide and the reference manual).

          Show
          Knut Anders Hatlen added a comment - Attaching a patch that removes the dita.regex target (and also the related check.regex.done target) from build.xml, and reverts the unneeded customization in two of DITA's XSL files that we have checked in under lib. The docs are still built just fine in my environment with this change (tested with the getting started guide and the reference manual).
          Knut Anders Hatlen made changes -
          Attachment d5354.diff [ 12487948 ]
          Knut Anders Hatlen made changes -
          Issue & fix info [Patch Available]
          Hide
          Knut Anders Hatlen added a comment -

          Committed revision 1152149.

          Show
          Knut Anders Hatlen added a comment - Committed revision 1152149.
          Knut Anders Hatlen made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Issue & fix info [Patch Available]
          Fix Version/s 10.9.0.0 [ 12316344 ]
          Resolution Fixed [ 1 ]
          Hide
          Kim Haase added a comment -

          Thank you very much, Knut, for figuring out that that target was unneeded. I see no problems with the change either.

          Show
          Kim Haase added a comment - Thank you very much, Knut, for figuring out that that target was unneeded. I see no problems with the change either.
          Hide
          Knut Anders Hatlen added a comment -

          Merged fix to 10.8 and committed revision 1160270.

          Show
          Knut Anders Hatlen added a comment - Merged fix to 10.8 and committed revision 1160270.
          Knut Anders Hatlen made changes -
          Fix Version/s 10.8.1.6 [ 12316676 ]
          Affects Version/s 10.8.1.2 [ 12316362 ]
          Hide
          Myrna van Lunteren added a comment -

          attempt to adjust release notes

          Show
          Myrna van Lunteren added a comment - attempt to adjust release notes
          Myrna van Lunteren made changes -
          Component/s Build tools [ 11405 ]
          Hide
          Myrna van Lunteren added a comment -

          more tweaking for release notes

          Show
          Myrna van Lunteren added a comment - more tweaking for release notes
          Myrna van Lunteren made changes -
          Component/s Documentation [ 11406 ]
          Myrna van Lunteren made changes -
          Component/s Documentation [ 11406 ]
          Myrna van Lunteren made changes -
          Fix Version/s 10.8.2.0 [ 12317955 ]
          Fix Version/s 10.8.1.6 [ 12316676 ]
          Myrna van Lunteren made changes -
          Fix Version/s 10.8.2.2 [ 12317968 ]
          Fix Version/s 10.8.2.0 [ 12317955 ]
          Knut Anders Hatlen made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Workflow jira [ 12623697 ] Default workflow, editable Closed status [ 12801182 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open In Progress In Progress
          3m 50s 1 Knut Anders Hatlen 27/Jul/11 08:35
          In Progress In Progress Resolved Resolved
          2d 46m 1 Knut Anders Hatlen 29/Jul/11 09:21
          Resolved Resolved Closed Closed
          361d 8h 4m 1 Knut Anders Hatlen 24/Jul/12 17:26

            People

            • Assignee:
              Knut Anders Hatlen
              Reporter:
              Knut Anders Hatlen
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development