Derby
  1. Derby
  2. DERBY-5238

VARCHAR size typos in some documentation topics

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.8.1.2
    • Fix Version/s: 10.8.2.2, 10.9.1.0
    • Component/s: Documentation
    • Labels:
      None

      Description

      In the following topics, the size limit for VARCHAR has a typo (32762 instead of 32672):

      rtoolsimport64241.dita, "Parameters for the import procedures" (COLUMNINDEXES entry)
      rrefgetdbpropfunc.dita, "SYSCS_UTIL.SYSCS_GET_DATABASE_PROPERTY system function"
      rrefsyscsruntimestatsfunc.dita, "SYSCS_UTIL.SYSCS_GET_RUNTIMESTATISTICS system function"
      rrefimportdataproc.dita, "SYSCS_UTIL.SYSCS_IMPORT_DATA system procedure"
      rrefimportdataproclobs.dita, "SYSCS_UTIL.SYSCS_IMPORT_DATA_LOBS_FROM_EXTFILE system procedure"

      These errors should be fixed to prevent user confusion.

      1. DERBY-5238.diff
        11 kB
        Kim Haase
      2. DERBY-5238.stat
        0.2 kB
        Kim Haase
      3. DERBY-5238.zip
        12 kB
        Kim Haase
      4. DERBY-5238-2.diff
        5 kB
        Kim Haase
      5. DERBY-5238-2.stat
        0.2 kB
        Kim Haase
      6. DERBY-5238-3.diff
        5 kB
        Kim Haase
      7. DERBY-5238-4.diff
        5 kB
        Kim Haase

        Activity

        Hide
        Kim Haase added a comment -

        Changes have appeared in Latest Alpha Manuals.

        Show
        Kim Haase added a comment - Changes have appeared in Latest Alpha Manuals.
        Hide
        Kim Haase added a comment -

        Committed DERBY-5238-4.diff to 10.8 code branch at revision 1143962.

        Show
        Kim Haase added a comment - Committed DERBY-5238 -4.diff to 10.8 code branch at revision 1143962.
        Hide
        Kim Haase added a comment -

        Adding yet another patch because the revision number has changed.

        Show
        Kim Haase added a comment - Adding yet another patch because the revision number has changed.
        Hide
        Kim Haase added a comment -

        Since a couple of the files have changed since the patch was committed to the trunk, I think I need a new patch for the 10.8 branch (DERBY-5238-3.diff, attached). I'll commit this in a day or so unless I hear otherwise.

        Show
        Kim Haase added a comment - Since a couple of the files have changed since the patch was committed to the trunk, I think I need a new patch for the 10.8 branch ( DERBY-5238 -3.diff, attached). I'll commit this in a day or so unless I hear otherwise.
        Hide
        Kim Haase added a comment -

        For the sake of consistency, it seems like a good idea to commit the code comment changes to the 10.8 branch as well, since the issue shows up in Myrna's list from 6/20. Reopening to do this.

        Show
        Kim Haase added a comment - For the sake of consistency, it seems like a good idea to commit the code comment changes to the 10.8 branch as well, since the issue shows up in Myrna's list from 6/20. Reopening to do this.
        Hide
        Kim Haase added a comment -

        Changes have appeared in Latest Alpha Manuals.

        Show
        Kim Haase added a comment - Changes have appeared in Latest Alpha Manuals.
        Hide
        Kim Haase added a comment -

        Committed patch DERBY-5238.diff to documentation trunk at revision 1125079.
        Merged to 10.8 doc branch at revision 1125084.

        Committed patch DERBY-5238-2.diff to code trunk at revision 1125447.

        Show
        Kim Haase added a comment - Committed patch DERBY-5238 .diff to documentation trunk at revision 1125079. Merged to 10.8 doc branch at revision 1125084. Committed patch DERBY-5238 -2.diff to code trunk at revision 1125447.
        Hide
        Kim Haase added a comment -

        Thank you, Dag.

        Committed patch DERBY-5238-2.diff to code trunk at revision 1125447.

        Show
        Kim Haase added a comment - Thank you, Dag. Committed patch DERBY-5238 -2.diff to code trunk at revision 1125447.
        Hide
        Dag H. Wanvik added a comment -

        The code comment changes look good to me. +1

        Show
        Dag H. Wanvik added a comment - The code comment changes look good to me. +1
        Hide
        Kim Haase added a comment -

        Attaching DERBY-5238-2.diff and DERBY-5238-2.stat, with changes to the following files:

        M java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java
        M java/engine/org/apache/derby/catalog/SystemProcedures.java
        M java/drda/org/apache/derby/impl/drda/DDMReader.java

        Please let me know if these changes seem correct.

        Show
        Kim Haase added a comment - Attaching DERBY-5238 -2.diff and DERBY-5238 -2.stat, with changes to the following files: M java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java M java/engine/org/apache/derby/catalog/SystemProcedures.java M java/drda/org/apache/derby/impl/drda/DDMReader.java Please let me know if these changes seem correct.
        Hide
        Kim Haase added a comment -

        Thanks very much, Rick!

        Committed patch DERBY-5238.diff to documentation trunk at revision 1125079.
        Merged to 10.8 doc branch at revision 1125084.

        As I noted in comments on DERBY-5226, there are also a few places in code comments that contain the same misleading typo (32762) – this might be how it got into the docs:

        java/engine/org/apache/derby/catalog/SystemProcedures.java
        java/drda/org/apache/derby/impl/drda/DDMReader.java
        java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java

        I wonder if the DDMReader.java occurrence might be a special case (although 32672 occurs in java/drda/org/apache/derby/impl/drda/DRDAConnThread.java)? Anyway, I'll work on a second patch to fix these. I can't do any harm since these are in comments, and I'll make sure the trunk builds (I won't worry about the branch here).

        Show
        Kim Haase added a comment - Thanks very much, Rick! Committed patch DERBY-5238 .diff to documentation trunk at revision 1125079. Merged to 10.8 doc branch at revision 1125084. As I noted in comments on DERBY-5226 , there are also a few places in code comments that contain the same misleading typo (32762) – this might be how it got into the docs: java/engine/org/apache/derby/catalog/SystemProcedures.java java/drda/org/apache/derby/impl/drda/DDMReader.java java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java I wonder if the DDMReader.java occurrence might be a special case (although 32672 occurs in java/drda/org/apache/derby/impl/drda/DRDAConnThread.java)? Anyway, I'll work on a second patch to fix these. I can't do any harm since these are in comments, and I'll make sure the trunk builds (I won't worry about the branch here).
        Hide
        Rick Hillegas added a comment -

        Thanks Kim. Looks good to me. I have no strong feelings about spacing. +1

        Show
        Rick Hillegas added a comment - Thanks Kim. Looks good to me. I have no strong feelings about spacing. +1
        Hide
        Kim Haase added a comment -

        Attaching DERBY-5238.diff, DERBY-5238.stat, and DERBY-5238.zip, with changes as follows:

        M src/ref/rrefimportdataproc.dita
        M src/ref/rrefgetdbpropfunc.dita
        M src/ref/rrefimportdataproclobs.dita
        M src/ref/rrefsyscsruntimestatsfunc.dita
        M src/tools/rtoolsimport64241.dita

        I muddied the waters a bit by also regularizing some inconsistent spacing between data types and parentheses. Any strong views on this?

        Thanks for your feedback.

        Show
        Kim Haase added a comment - Attaching DERBY-5238 .diff, DERBY-5238 .stat, and DERBY-5238 .zip, with changes as follows: M src/ref/rrefimportdataproc.dita M src/ref/rrefgetdbpropfunc.dita M src/ref/rrefimportdataproclobs.dita M src/ref/rrefsyscsruntimestatsfunc.dita M src/tools/rtoolsimport64241.dita I muddied the waters a bit by also regularizing some inconsistent spacing between data types and parentheses. Any strong views on this? Thanks for your feedback.

          People

          • Assignee:
            Kim Haase
            Reporter:
            Kim Haase
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development