[DERBY-4814] Minor cleanup of Derby151Test

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 10.7.1.1
• Fix Version/s: 11.0.0.0
• Component/s: Test
• Assignee: Knut Anders Hatlen
• Reporter: Knut Anders Hatlen
• Created: 23/Sep/10 15:58
• Updated: 29/Nov/10 14:21
• Resolved: 24/Sep/10 09:49

Description

I noticed a couple of tiny issues with Derby151Test:

1) baseSuite() generates two TestSuite instances wrapping Derby151Test.class, but throws one of them away.

2) baseSuite() adds the tests if JDBC.vmSupportsJSR169() returns false. I remember we had discussions where it was said that we should express these conditions in positive terms (http://mail-archives.apache.org/mod_mbox/db-derby-dev/200608.mbox/[e-mail]%3E). That is, since this test requires DriverManager, the method should say "add this test if we have a JDBC version that includes DriverManager", not "don't add this test if we have a JDBC version that doesn't support DriverManager".

3) d151() calls Thread.currentThread().interrupted(), which is a static method, so it would be clearer if it said Thread.interrupted().

4) Some unused imports.