Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.5.1.1, 10.6.1.0
    • Fix Version/s: 10.11.0.0
    • Component/s: Test
    • Labels:
      None

      Description

      I received a request to remove JCC testing from the derby suite. The user had a very old jcc version in their classpath 2.4 and 10.5 tests were failing with:

      com.ibm.db2.jcc.c.SqlException: DB2 SQL error: SQLCODE: -1, SQLSTATE: XJ040, SQLERRMC: Failed to start database '/results/axxon/58712/laka10a-derby-m101-20100830-003810/derbyall/derbynetmats/DerbyNet/derbynetmats/dblook_test_net_territory//wombat', see the next exception for details.::SQLSTATE: XJ001Java exception: 'Access denied (java.util.PropertyPermission com.ibm.crypto.provider.FIPSMODE read): java.security.AccessControlException'.
      at com.ibm.db2.jcc.c.o.a(o.java:3219)
      at com.ibm.db2.jcc.a.cb.q(cb.java:653)
      at com.ibm.db2.jcc.a.cb.p(cb.java:541)
      at com.ibm.db2.jcc.a.cb.l(cb.java:363)
      at com.ibm.db2.jcc.a.cb.d(cb.java:145)
      at com.ibm.db2.jcc.a.b.Sb(b.java:1274)
      at com.ibm.db2.jcc.a.b.a(b.java:1166)
      at com.ibm.db2.jcc.a.b.q(b.java:934)
      at com.ibm.db2.jcc.a.b.a(b.java:702)
      at com.ibm.db2.jcc.a.b.(b.java:305)
      at com.ibm.db2.jcc.DB2Driver.connect(DB2Driver.java:162)
      at java.sql.DriverManager.getConnection(DriverManager.java:322)
      at java.sql.DriverManager.getConnection(DriverManager.java:273)
      at org.apache.derby.tools.dblook.go(Unknown Source)
      at org.apache.derby.tools.dblook.(Unknown Source)
      at org.apache.derbyTesting.functionTests.tests.tools.dblook_test.lookThree(dblook_test.java:417)
      at org.apache.derbyTesting.functionTests.tests.tools.dblook_test.runTest(dblook_test.java:283)
      at org.apache.derbyTesting.functionTests.tests.derbynet.dblook_test_net_territory.doTest(dblook_test_net_territory.java:65)
      at org.apache.derbyTesting.functionTests.tests.derbynet.dblook_test_net_territory.main(dblook_test_net_territory.java:41)

      Now that I look at it more closely, their actual problem might be on the server side and JCC just reporting it but good to get the JCC tests out of the mix when people accidentally have it in their classpath anyway.

      1. JCC_Removal_DONOTCOMMIT_Dec29.txt
        4 kB
        Jayaram Subramanian
      2. stat_Dec29_JCC.txt
        0.9 kB
        Jayaram Subramanian
      3. JCCRemoval_Jan112011.txt
        22 kB
        Jayaram Subramanian
      4. Stat_JCCRemoval_Jan112011.txt
        2 kB
        Jayaram Subramanian
      5. jccremoval_Jan27.txt
        22 kB
        Jayaram Subramanian
      6. jccremoval_stats_Jan27.txt
        2 kB
        Jayaram Subramanian
      7. JCCRemoval_Feb182011.txt
        21 kB
        Jayaram Subramanian
      8. JCCRemovalStat_Feb182011.txt
        2 kB
        Jayaram Subramanian
      9. d4785-compat-1a.diff
        31 kB
        Knut Anders Hatlen
      10. diff-jan172012.diff
        487 kB
        Jayaram Subramanian
      11. stat-jan172012.stat
        1 kB
        Jayaram Subramanian
      12. Feb142012.diff
        18 kB
        Jayaram Subramanian
      13. Feb142012.stat
        2 kB
        Jayaram Subramanian

        Activity

        Gavin made changes -
        Workflow jira [ 12519256 ] Default workflow, editable Closed status [ 12802632 ]
        Myrna van Lunteren made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 10.11.0.0 [ 12324243 ]
        Resolution Fixed [ 1 ]
        Hide
        ASF subversion and git services added a comment -

        Commit 1492887 from Myrna van Lunteren
        [ https://svn.apache.org/r1492887 ]

        DERBY-4785; Remove JCC tests and references to JCC in test code
        Removing the last few files from the suites dir and the entire master/DerbyNet directory.

        Show
        ASF subversion and git services added a comment - Commit 1492887 from Myrna van Lunteren [ https://svn.apache.org/r1492887 ] DERBY-4785 ; Remove JCC tests and references to JCC in test code Removing the last few files from the suites dir and the entire master/DerbyNet directory.
        Hide
        Myrna van Lunteren added a comment -

        I think this issue is practically done, just a few more deletes; the final files in the suites directory that refer to DerbyNet and the DerbyNet canon directory in functionTests/master:
        D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet
        D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\holdCursorJDBC30.out
        D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\Stream.out
        D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\synonym.out
        D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\dblook_test_net.out
        D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\dblook_test_net_territory.out
        D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\maxfieldsize.out
        D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\holdCursorExternalSortJDBC30.out
        D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\holdCursorIJ.out
        D java\testing\org\apache\derbyTesting\functionTests\suites\DerbyNetRemote.exclude
        D java\testing\org\apache\derbyTesting\functionTests\suites\j9derbynetmats.properties
        D java\testing\org\apache\derbyTesting\functionTests\suites\DerbyNetUseprocess.exclude
        D java\testing\org\apache\derbyTesting\functionTests\suites\DerbyNet.exclude

        Show
        Myrna van Lunteren added a comment - I think this issue is practically done, just a few more deletes; the final files in the suites directory that refer to DerbyNet and the DerbyNet canon directory in functionTests/master: D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\holdCursorJDBC30.out D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\Stream.out D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\synonym.out D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\dblook_test_net.out D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\dblook_test_net_territory.out D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\maxfieldsize.out D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\holdCursorExternalSortJDBC30.out D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\holdCursorIJ.out D java\testing\org\apache\derbyTesting\functionTests\suites\DerbyNetRemote.exclude D java\testing\org\apache\derbyTesting\functionTests\suites\j9derbynetmats.properties D java\testing\org\apache\derbyTesting\functionTests\suites\DerbyNetUseprocess.exclude D java\testing\org\apache\derbyTesting\functionTests\suites\DerbyNet.exclude
        Hide
        Knut Anders Hatlen added a comment -

        I think the link to JCC is that DerbyNet.exclude lists the tests to skip if we run the old test harness with the JCC driver. Since we don't support running tests against JCC anymore, we don't need the files that tell which tests would fail when run against JCC.

        Show
        Knut Anders Hatlen added a comment - I think the link to JCC is that DerbyNet.exclude lists the tests to skip if we run the old test harness with the JCC driver. Since we don't support running tests against JCC anymore, we don't need the files that tell which tests would fail when run against JCC.
        Hide
        Jayaram Subramanian added a comment -

        Found that derbynet.exclude had references to 2 files rsgetXXXcolumnNames.java and SetQueryTimeoutTest.java. But rsgetXXXcolumnNames.java file didnt have any references to jcc. So i am curious to know how derbynet.exclude is linked with jcc removal..

        Show
        Jayaram Subramanian added a comment - Found that derbynet.exclude had references to 2 files rsgetXXXcolumnNames.java and SetQueryTimeoutTest.java. But rsgetXXXcolumnNames.java file didnt have any references to jcc. So i am curious to know how derbynet.exclude is linked with jcc removal..
        Kristian Waagan made changes -
        Issue & fix info Patch Available [ 10102 ]
        Hide
        Kristian Waagan added a comment -

        Clearing patch available flag.
        There seems to be some more work left to do on this issue.

        Show
        Kristian Waagan added a comment - Clearing patch available flag. There seems to be some more work left to do on this issue.
        Hide
        Myrna van Lunteren added a comment -

        I'm thinking that there are still some suite files for the old harness that can be removed.
        e.g. functionTests/suites/DerbyNet.exclude, DerbyNetUseProcess.exclude, j9derbynetmats (we're not really supporting j9 with networkserver anyway), etc.

        Show
        Myrna van Lunteren added a comment - I'm thinking that there are still some suite files for the old harness that can be removed. e.g. functionTests/suites/DerbyNet.exclude, DerbyNetUseProcess.exclude, j9derbynetmats (we're not really supporting j9 with networkserver anyway), etc.
        Hide
        Myrna van Lunteren added a comment -

        Thank you Jayaram for this patch.
        There were still a few minor nits which I fixed up; a few references to failing with DB2Client, BlobClob4BlobTest had been modified since your last refresh and so I just redid that one, and I removed further references to JCC in the javadoc of a few tests, in particular, NSSecurityMechanismTest.

        Committed with revision 1244295.

        Is there more work to be done here?

        Show
        Myrna van Lunteren added a comment - Thank you Jayaram for this patch. There were still a few minor nits which I fixed up; a few references to failing with DB2Client, BlobClob4BlobTest had been modified since your last refresh and so I just redid that one, and I removed further references to JCC in the javadoc of a few tests, in particular, NSSecurityMechanismTest. Committed with revision 1244295. Is there more work to be done here?
        Jayaram Subramanian made changes -
        Attachment Feb142012.diff [ 12514441 ]
        Attachment Feb142012.stat [ 12514442 ]
        Hide
        Jayaram Subramanian added a comment -

        Attaching the updated patch as per the previous comments

        Show
        Jayaram Subramanian added a comment - Attaching the updated patch as per the previous comments
        Hide
        Myrna van Lunteren added a comment -

        Thank you for your continued interest in Derby!

        I looked visually at the .diff file from the patch and I have the following comments:

        • a number of the tests have a lot of whitespace differences. In particular is the case for the tests jdbcapi/HoldabilityTest.java, jdbcapi/ConcurrencyTest.java, jdbcapi/DriverTest.java, jdbcapi/BlobClob4BlobTest.java, jdbcapi/ProcedureTest.java.
          It seems to me that you've reformatted those tests with a tab as the indent, instead of the 4 spaces as per our formatting convention.
          Typically, we do not touch code that we don't have to - it makes the diff huge, and comparing the actual changes impractical.
        • some of the tests that have only minimal changes still have unnecessary whitespace changes, e.g.
          jdbcapi/XATransactionTest.java. In fact, I don't see why that test needed to be changed at all?
          From the .diff file:
          --------------------------
          @@ -25,6 +25,7 @@
          import java.sql.Connection;
          import java.sql.ResultSet;
          import java.sql.SQLException;
          +
          import java.sql.Statement;
          import javax.sql.XAConnection;
          import javax.sql.XADataSource;
          @@ -426,6 +427,7 @@
          assertEquals(XAException.XAER_RMFAIL, xae.errorCode);
          }
          }
          +

        /**
        ----------------------------
        If there's no real reference to DB2Client or JCC here this file should get svn revert-ed.

        • A number of the changes remove the if clauses relating to DB2Client, but leave the comments in place. The comments should go also. This is for instance the case with lang/TableFunctionTest.java. From the .diff:
          --------------------
          {
          // skip this test if using the DB2 client, which does not support the
          // JDBC4 metadata calls.
        • if ( usingDB2Client() ) { return; }
        • -
          println( "\nExpecting correct function metadata from " + functionName );
          ResultSet rs = getFunctions( null, "APP", functionName );
          JDBC.assertFullResultSet( rs, expectedGetFunctionsResult, false );
          ---------------------
          The comment lines '//skip this test if using the DB2 client, which does not support the" and "// JDBC4 metadata calls." should also be removed.
          Similar comments are in many of the other tests.

        Show
        Myrna van Lunteren added a comment - Thank you for your continued interest in Derby! I looked visually at the .diff file from the patch and I have the following comments: a number of the tests have a lot of whitespace differences. In particular is the case for the tests jdbcapi/HoldabilityTest.java, jdbcapi/ConcurrencyTest.java, jdbcapi/DriverTest.java, jdbcapi/BlobClob4BlobTest.java, jdbcapi/ProcedureTest.java. It seems to me that you've reformatted those tests with a tab as the indent, instead of the 4 spaces as per our formatting convention. Typically, we do not touch code that we don't have to - it makes the diff huge, and comparing the actual changes impractical. some of the tests that have only minimal changes still have unnecessary whitespace changes, e.g. jdbcapi/XATransactionTest.java. In fact, I don't see why that test needed to be changed at all? From the .diff file: -------------------------- @@ -25,6 +25,7 @@ import java.sql.Connection; import java.sql.ResultSet; import java.sql.SQLException; + import java.sql.Statement; import javax.sql.XAConnection; import javax.sql.XADataSource; @@ -426,6 +427,7 @@ assertEquals(XAException.XAER_RMFAIL, xae.errorCode); } } + /** ---------------------------- If there's no real reference to DB2Client or JCC here this file should get svn revert-ed. A number of the changes remove the if clauses relating to DB2Client, but leave the comments in place. The comments should go also. This is for instance the case with lang/TableFunctionTest.java. From the .diff: -------------------- { // skip this test if using the DB2 client, which does not support the // JDBC4 metadata calls. if ( usingDB2Client() ) { return; } - println( "\nExpecting correct function metadata from " + functionName ); ResultSet rs = getFunctions( null, "APP", functionName ); JDBC.assertFullResultSet( rs, expectedGetFunctionsResult, false ); --------------------- The comment lines '//skip this test if using the DB2 client, which does not support the" and "// JDBC4 metadata calls." should also be removed. Similar comments are in many of the other tests.
        Jayaram Subramanian made changes -
        Attachment diff-jan172012.diff [ 12511082 ]
        Attachment stat-jan172012.stat [ 12511083 ]
        Hide
        Jayaram Subramanian added a comment -

        As a initial patch for removing all jcc references removed all the references to IsDB2Client method in test classes

        Show
        Jayaram Subramanian added a comment - As a initial patch for removing all jcc references removed all the references to IsDB2Client method in test classes
        Hide
        Knut Anders Hatlen added a comment -

        Committed d4785-compat-1a.diff to trunk with revision 1161422.

        Show
        Knut Anders Hatlen added a comment - Committed d4785-compat-1a.diff to trunk with revision 1161422.
        Knut Anders Hatlen made changes -
        Attachment d4785-compat-1a.diff [ 12491472 ]
        Hide
        Knut Anders Hatlen added a comment -

        I'm attaching a patch that removes handling of JCC and Java 1.3 in the compatibility test. JCC was only needed when using 10.0.2.1 on the client side in client/server compatibility testing, since 10.0.2.1 didn't have its own client driver. The patch makes the compatibility test skip combinations with 10.0.2.1 on the client side. The 10.0.2.1 server is however still tested.

        I've tested the patch by running the compatibility test both from the Ant script and from the JUnit suite, and it passed in both configurations.

        Show
        Knut Anders Hatlen added a comment - I'm attaching a patch that removes handling of JCC and Java 1.3 in the compatibility test. JCC was only needed when using 10.0.2.1 on the client side in client/server compatibility testing, since 10.0.2.1 didn't have its own client driver. The patch makes the compatibility test skip combinations with 10.0.2.1 on the client side. The 10.0.2.1 server is however still tested. I've tested the patch by running the compatibility test both from the Ant script and from the JUnit suite, and it passed in both configurations.
        Jayaram Subramanian made changes -
        Issue & fix info [Patch Available]
        Jayaram Subramanian made changes -
        Attachment JCCRemoval_Feb182011.txt [ 12471395 ]
        Attachment JCCRemovalStat_Feb182011.txt [ 12471396 ]
        Hide
        Jayaram Subramanian added a comment -

        Patch for removal of JCC references. Also the issue which occurred in previous patch build has been addressed.

        Show
        Jayaram Subramanian added a comment - Patch for removal of JCC references. Also the issue which occurred in previous patch build has been addressed.
        Tiago R. Espinha made changes -
        Issue & fix info [Patch Available]
        Hide
        Tiago R. Espinha added a comment -

        This is the error I got by the way:

        junitcomponents:
        [javac] Compiling 1 source file to /Users/tiago/Desktop/Derby/cleanTrunk/classes
        [javac] /Users/tiago/Desktop/Derby/cleanTrunk/java/testing/org/apache/derbyTesting/junit/TestConfiguration.java:1241: cannot find symbol
        [javac] symbol : variable DB2CLIENT
        [javac] location: class org.apache.derbyTesting.junit.JDBCClient
        [javac] jdbcClient = JDBCClient.DB2CLIENT;
        [javac] ^
        [javac] 1 error

        BUILD FAILED
        /Users/tiago/Desktop/Derby/cleanTrunk/build.xml:584: The following error occurred while executing this line:
        /Users/tiago/Desktop/Derby/cleanTrunk/java/testing/build.xml:59: The following error occurred while executing this line:
        /Users/tiago/Desktop/Derby/cleanTrunk/java/testing/org/apache/derbyTesting/junit/build.xml:74: Compile failed; see the compiler error output for details.

        Total time: 8 seconds

        Show
        Tiago R. Espinha added a comment - This is the error I got by the way: junitcomponents: [javac] Compiling 1 source file to /Users/tiago/Desktop/Derby/cleanTrunk/classes [javac] /Users/tiago/Desktop/Derby/cleanTrunk/java/testing/org/apache/derbyTesting/junit/TestConfiguration.java:1241: cannot find symbol [javac] symbol : variable DB2CLIENT [javac] location: class org.apache.derbyTesting.junit.JDBCClient [javac] jdbcClient = JDBCClient.DB2CLIENT; [javac] ^ [javac] 1 error BUILD FAILED /Users/tiago/Desktop/Derby/cleanTrunk/build.xml:584: The following error occurred while executing this line: /Users/tiago/Desktop/Derby/cleanTrunk/java/testing/build.xml:59: The following error occurred while executing this line: /Users/tiago/Desktop/Derby/cleanTrunk/java/testing/org/apache/derbyTesting/junit/build.xml:74: Compile failed; see the compiler error output for details. Total time: 8 seconds
        Hide
        Tiago R. Espinha added a comment -

        Hi Jayaram,

        I was reviewing your latest patch and it doesn't seem like it compiles. Could you check what's wrong with it? I'll commit it after it's fixed.

        Thanks

        Show
        Tiago R. Espinha added a comment - Hi Jayaram, I was reviewing your latest patch and it doesn't seem like it compiles. Could you check what's wrong with it? I'll commit it after it's fixed. Thanks
        Jayaram Subramanian made changes -
        Issue & fix info [Patch Available]
        Jayaram Subramanian made changes -
        Attachment jccremoval_Jan27.txt [ 12469631 ]
        Attachment jccremoval_stats_Jan27.txt [ 12469632 ]
        Hide
        Jayaram Subramanian added a comment -

        Inline comments for jcc usingdb2client removal have been updated as per review .

        Show
        Jayaram Subramanian added a comment - Inline comments for jcc usingdb2client removal have been updated as per review .
        Hide
        Kathey Marsden added a comment -

        Hi Jayaram,

        On the JCCRemoval_Jan112011.txt patch, my only comment would be that although I am usually a big fan of comments, I think in this case, the comments like
        //Derby 4785 removed usingDB2Client as a part of JCC removal
        and previously existing comments about JCC and DB2 can just be removed.

        The svn history will show clearly that JCC was removed and hopefully at the end of this effort we just won't find DB2 and JCC anywhere.

        I don't see anything in the change that should cause your tests to stop abruptly. Were there any javacore files left or anything like that. If not I would suggest, make the comment changes and rerun suites.All. If it still won't run on your machine I will give the new patch a spin on mine.

        Show
        Kathey Marsden added a comment - Hi Jayaram, On the JCCRemoval_Jan112011.txt patch, my only comment would be that although I am usually a big fan of comments, I think in this case, the comments like //Derby 4785 removed usingDB2Client as a part of JCC removal and previously existing comments about JCC and DB2 can just be removed. The svn history will show clearly that JCC was removed and hopefully at the end of this effort we just won't find DB2 and JCC anywhere. I don't see anything in the change that should cause your tests to stop abruptly. Were there any javacore files left or anything like that. If not I would suggest, make the comment changes and rerun suites.All. If it still won't run on your machine I will give the new patch a spin on mine.
        Jayaram Subramanian made changes -
        Attachment JCCRemoval_Jan112011.txt [ 12468105 ]
        Attachment Stat_JCCRemoval_Jan112011.txt [ 12468106 ]
        Hide
        Jayaram Subramanian added a comment -

        Patch submitted after removal of references to "usingDB2Client" in Junit test classes.

        Show
        Jayaram Subramanian added a comment - Patch submitted after removal of references to "usingDB2Client" in Junit test classes.
        Kathey Marsden made changes -
        Issue & fix info [Patch Available]
        Hide
        Kathey Marsden added a comment -

        Thanks Jayaram for the patch! I committed it to trunk with revision 1054146. Next I suggest at removing JCC from the JUnit tests per Knut's earlier comment.
        https://issues.apache.org/jira/browse/DERBY-4785?focusedCommentId=12925956&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12925956

        Happy New Year!

        Show
        Kathey Marsden added a comment - Thanks Jayaram for the patch! I committed it to trunk with revision 1054146. Next I suggest at removing JCC from the JUnit tests per Knut's earlier comment. https://issues.apache.org/jira/browse/DERBY-4785?focusedCommentId=12925956&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12925956 Happy New Year!
        Myrna van Lunteren made changes -
        Issue & fix info [Patch Available]
        Hide
        Myrna van Lunteren added a comment -

        checking the patch available box so committers get automatically reminded of a patch waiting for review/commit.

        Show
        Myrna van Lunteren added a comment - checking the patch available box so committers get automatically reminded of a patch waiting for review/commit.
        Jayaram Subramanian made changes -
        Attachment JCC_Removal_DONOTCOMMIT_Dec29.txt [ 12467152 ]
        Attachment stat_Dec29_JCC.txt [ 12467153 ]
        Hide
        Jayaram Subramanian added a comment -

        Attaching the patch and stat files for JCC Removal.

        Show
        Jayaram Subramanian added a comment - Attaching the patch and stat files for JCC Removal.
        Jayaram Subramanian made changes -
        Assignee Jayaram Subramanian [ rsjay1976 ]
        Hide
        Jayaram Subramanian added a comment -

        Assigning to myself

        Show
        Jayaram Subramanian added a comment - Assigning to myself
        Hide
        Kathey Marsden added a comment -

        Good point. Thanks Myrna I didn't notice those were linked up.

        Show
        Kathey Marsden added a comment - Good point. Thanks Myrna I didn't notice those were linked up.
        Hide
        Myrna van Lunteren added a comment -

        re removal of derbynetmats suites...You can't just remove those files; you need to add the contents of derbynetmats.runall to derbynetclientmats.runall, and replace the 'derbynetmats' suite reference in derbynetclientmats.properties with 'jdbcapi jdbc20'.

        Show
        Myrna van Lunteren added a comment - re removal of derbynetmats suites...You can't just remove those files; you need to add the contents of derbynetmats.runall to derbynetclientmats.runall, and replace the 'derbynetmats' suite reference in derbynetclientmats.properties with 'jdbcapi jdbc20'.
        Hide
        Knut Anders Hatlen added a comment -

        For the removal from the JUnit tests, I would suggest that you go through the callers of JDBCClient.isDB2Client() and BaseJDBCTestCase.usingDB2Client(), and finally remove those two methods themselves. I think this will remove most of the JCC-specific code in the JUnit tests.

        There's also a less frequently used method called DerbyJUnitTest.usingDB2Client().

        Show
        Knut Anders Hatlen added a comment - For the removal from the JUnit tests, I would suggest that you go through the callers of JDBCClient.isDB2Client() and BaseJDBCTestCase.usingDB2Client(), and finally remove those two methods themselves. I think this will remove most of the JCC-specific code in the JUnit tests. There's also a less frequently used method called DerbyJUnitTest.usingDB2Client().
        Hide
        Kathey Marsden added a comment -

        On the mailing list Jayaram asked for first steps on this issue.

        I think a good first step would be to remove the derbynetmats suite from derbyall.
        Basically all that would need to be done for this first patch would be to remove derbynetmats from

        java/testing/org/apache/derbyTesting/functionTests/suites/derbyall.properties and remove the erbynetmats.properties derbynetmats.runall and run tests to make sure there is no unexpected mpact.

        Then as Dag suggest we can do the bare minimum in RunTest, RunSuite etc to make sure it doesn't get loaded and finally do a more careful removal of the jcc references in the JUnit test infrastructure, but I think the first step would be just to remove derbynetmats from the suite.

        Show
        Kathey Marsden added a comment - On the mailing list Jayaram asked for first steps on this issue. I think a good first step would be to remove the derbynetmats suite from derbyall. Basically all that would need to be done for this first patch would be to remove derbynetmats from java/testing/org/apache/derbyTesting/functionTests/suites/derbyall.properties and remove the erbynetmats.properties derbynetmats.runall and run tests to make sure there is no unexpected mpact. Then as Dag suggest we can do the bare minimum in RunTest, RunSuite etc to make sure it doesn't get loaded and finally do a more careful removal of the jcc references in the JUnit test infrastructure, but I think the first step would be just to remove derbynetmats from the suite.
        Myrna van Lunteren made changes -
        Field Original Value New Value
        Parent Issue DERBY-4597 [ DERBY-4597 ] DERBY-4596 [ DERBY-4596 ]
        Kathey Marsden created issue -

          People

          • Assignee:
            Jayaram Subramanian
            Reporter:
            Kathey Marsden
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development