Derby
  1. Derby
  2. DERBY-4770

Files missing svn:eol-style (August 2010)

    Details

      Description

      Some new files have been added without the svn:eol-style property set. These files should have the property set with value "native".

      1. derby-4770-3a-eol_style_10_5.diff
        2 kB
        Kristian Waagan
      2. derby-4770-2a-eol_style_10_6.diff
        2 kB
        Kristian Waagan
      3. derby-4770-1a-eol_style_trunk.diff
        3 kB
        Kristian Waagan

        Activity

        Hide
        Kristian Waagan added a comment -

        Attached patch 1a, which sets the svn:eol-style to native for 14 files.
        Committed to trunk with revision 985120.

        Again, should such changes be backported?

        The list of files missing the property was compiled with the following script:
        for i in `find java/ -name "*.java"`; do
        svn info $i > /dev/null 2>&1 && ( svn proplist $i | grep svn:eol-style > /dev/null || echo "$i") >> /tmp/missing-eol-ALL.txt
        done

        For now I have left other types (non '.java') of files alone.

        Show
        Kristian Waagan added a comment - Attached patch 1a, which sets the svn:eol-style to native for 14 files. Committed to trunk with revision 985120. Again, should such changes be backported? The list of files missing the property was compiled with the following script: for i in `find java/ -name "*.java"`; do svn info $i > /dev/null 2>&1 && ( svn proplist $i | grep svn:eol-style > /dev/null || echo "$i") >> /tmp/missing-eol-ALL.txt done For now I have left other types (non '.java') of files alone.
        Hide
        Myrna van Lunteren added a comment -

        I think it worthwhile backporting svn-eol-style settings. I'm usually working on windows OS and I've had failing commits because of mixed-eol characters. Of course it can be corrected at that time, but...

        Show
        Myrna van Lunteren added a comment - I think it worthwhile backporting svn-eol-style settings. I'm usually working on windows OS and I've had failing commits because of mixed-eol characters. Of course it can be corrected at that time, but...
        Hide
        Kristian Waagan added a comment -

        Attached the diffs for branches 10.6 and 10.5.
        I didn't spot any Java files with the eol-style missing in 10.4.

        Show
        Kristian Waagan added a comment - Attached the diffs for branches 10.6 and 10.5. I didn't spot any Java files with the eol-style missing in 10.4.
        Hide
        Kristian Waagan added a comment -

        Committed patches 2a and 3a with revisions 993329 and 993330.
        Closing the issue.

        Show
        Kristian Waagan added a comment - Committed patches 2a and 3a with revisions 993329 and 993330. Closing the issue.

          People

          • Assignee:
            Kristian Waagan
            Reporter:
            Kristian Waagan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development