Derby
  1. Derby
  2. DERBY-4707

convert ShutdownDatabase.java into junit

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.7.1.1
    • Component/s: Test
    • Labels:
    • Urgency:
      Normal
    1. derby-4707.patch
      14 kB
      Yun Lee
    2. derby-4707.stat
      0.3 kB
      Kristian Waagan

      Issue Links

        Activity

        Hide
        Yun Lee added a comment -

        I have seen just now that there has already been a junit conversion for ShutdownDatabase named ShutdownDatabaseTest, which is added in Derby-2464() and works well. However, the original class ShutdownDatabase is still kept, I think this is not correct. So, I removed the outdated class and reference to it. Please check it, thanks!

        Show
        Yun Lee added a comment - I have seen just now that there has already been a junit conversion for ShutdownDatabase named ShutdownDatabaseTest, which is added in Derby-2464() and works well. However, the original class ShutdownDatabase is still kept, I think this is not correct. So, I removed the outdated class and reference to it. Please check it, thanks!
        Hide
        Kristian Waagan added a comment -

        Hi Yun,

        You are right the old class should be removed. When removing tests from the old harness, there is also most often a master file (contains expected output when running the test) to be removed as well (sometimes more than one).
        When deleting files it may be helpful to upload the output from svn stat to make sure the committer deletes the files. If only the patch is applied, an empty file will be left around.

        Committed changes to trunk with revision 956847.

        Thanks,

        Show
        Kristian Waagan added a comment - Hi Yun, You are right the old class should be removed. When removing tests from the old harness, there is also most often a master file (contains expected output when running the test) to be removed as well (sometimes more than one). When deleting files it may be helpful to upload the output from svn stat to make sure the committer deletes the files. If only the patch is applied, an empty file will be left around. Committed changes to trunk with revision 956847. Thanks,
        Hide
        Kristian Waagan added a comment -

        Added link to duplicate issue DERBY-2464.

        Show
        Kristian Waagan added a comment - Added link to duplicate issue DERBY-2464 .
        Hide
        Yun Lee added a comment -

        Thanks for your detailed advice, Kristian! I will do better in next patch!

        Show
        Yun Lee added a comment - Thanks for your detailed advice, Kristian! I will do better in next patch!

          People

          • Assignee:
            Yun Lee
            Reporter:
            Yun Lee
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development