Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-4600

Use ValueNodeList helper methods in CoalesceFunctionNode

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 10.6.1.0
    • 10.6.1.0
    • SQL
    • None

    Description

      CoalesceFunctionNode manually iterates over argumentsList (a ValueNodeList) in acceptChildren(), preprocess(), remapColumnReferencesToExpressions() and isEquivalent(). ValueNodeList has helper methods for the first three of those, and those helper methods should be used instead to simplify the code. There is no helper method for isEquivalent(), but since very similar code is also found in the isEquivalent() methods of BinaryListOperatorNode and ConditionalNode, we should add a new helper and use it in those classes too.

      Attachments

        1. helpers.diff
          5 kB
          Knut Anders Hatlen

        Activity

          People

            knutanders Knut Anders Hatlen
            knutanders Knut Anders Hatlen
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: