Derby
  1. Derby
  2. DERBY-4600

Use ValueNodeList helper methods in CoalesceFunctionNode

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.6.1.0
    • Fix Version/s: 10.6.1.0
    • Component/s: SQL
    • Labels:
      None

      Description

      CoalesceFunctionNode manually iterates over argumentsList (a ValueNodeList) in acceptChildren(), preprocess(), remapColumnReferencesToExpressions() and isEquivalent(). ValueNodeList has helper methods for the first three of those, and those helper methods should be used instead to simplify the code. There is no helper method for isEquivalent(), but since very similar code is also found in the isEquivalent() methods of BinaryListOperatorNode and ConditionalNode, we should add a new helper and use it in those classes too.

      1. helpers.diff
        5 kB
        Knut Anders Hatlen

        Activity

        Gavin made changes -
        Workflow jira [ 12503026 ] Default workflow, editable Closed status [ 12799691 ]
        Knut Anders Hatlen made changes -
        Status In Progress [ 3 ] Closed [ 6 ]
        Issue & fix info [Patch Available]
        Fix Version/s 10.6.0.0 [ 12313727 ]
        Resolution Fixed [ 1 ]
        Hide
        Knut Anders Hatlen added a comment -

        Committed revision 928649.

        Show
        Knut Anders Hatlen added a comment - Committed revision 928649.
        Knut Anders Hatlen made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Knut Anders Hatlen made changes -
        Assignee Knut Anders Hatlen [ knutanders ]
        Issue & fix info [Patch Available]
        Knut Anders Hatlen made changes -
        Field Original Value New Value
        Attachment helpers.diff [ 12439860 ]
        Hide
        Knut Anders Hatlen added a comment -

        Attaching a patch that makes CoalesceFunctionNode use helper methods instead of iterating over argumentsList manually. It also adds a new method isEquivalent() to ValueNodeList and uses it in BinaryListOperatorNode, CoalesceFunctionNode and ConditionalNode.

        All the regression tests ran cleanly with the patch.

        Show
        Knut Anders Hatlen added a comment - Attaching a patch that makes CoalesceFunctionNode use helper methods instead of iterating over argumentsList manually. It also adds a new method isEquivalent() to ValueNodeList and uses it in BinaryListOperatorNode, CoalesceFunctionNode and ConditionalNode. All the regression tests ran cleanly with the patch.
        Knut Anders Hatlen created issue -

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development