Derby
  1. Derby
  2. DERBY-4574

derby.jar not a valid R4 OSGi bundle

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.5.3.0
    • Fix Version/s: 10.5.3.1, 10.6.1.0
    • Component/s: Services
    • Labels:
      None

      Description

      The derby.jar has all the bundle metadata you would expect for it to be an OSGi bundle, except for the Bundle-ManifestVersion header. As a result it is not a valid R4 bundle, but will be treated as an R3 bundle.

      Looking at the metadata provided it looks as if the bundle should be an R4 bundle. Adding the following will make it a proper R4 bundle.

      Bundle-ManifestVersion: 2

        Issue Links

          Activity

          Hide
          Knut Anders Hatlen added a comment -

          [bulk update] Close all resolved issues that haven't been updated for more than one year.

          Show
          Knut Anders Hatlen added a comment - [bulk update] Close all resolved issues that haven't been updated for more than one year.
          Hide
          Bryan Pendleton added a comment -

          Thanks Myrna. I believe that checking the manifest contents was
          all the testing that I did when I first worked on this. I agree that a
          better test would be useful, but I think your checking the manifest
          is a good and adequate check for the successful backport of this change.

          Show
          Bryan Pendleton added a comment - Thanks Myrna. I believe that checking the manifest contents was all the testing that I did when I first worked on this. I agree that a better test would be useful, but I think your checking the manifest is a good and adequate check for the successful backport of this change.
          Hide
          Myrna van Lunteren added a comment -

          merged to 10.5 with revision 963799.
          svn merge command: svn merge -c 918152 https://svn.apache.org/repos/asf/db/derby/code/trunk

          I verified that appropriate entries are in the META-INF/MANIFEST.MF file in derby.jar and derbyclient.jar.

          Show
          Myrna van Lunteren added a comment - merged to 10.5 with revision 963799. svn merge command: svn merge -c 918152 https://svn.apache.org/repos/asf/db/derby/code/trunk I verified that appropriate entries are in the META-INF/MANIFEST.MF file in derby.jar and derbyclient.jar.
          Hide
          Myrna van Lunteren added a comment -

          I was contemplating this backport, but I think DERBY-4120 also should get backported. That would make the 10.6 and 10.5 build.xml files look similar with regards to OSGI elements.

          I already re-assigned this one, and will do the same for DERBY-4120, hope that's OK.

          I could not come up with any useful automated test, and I guess no one did when the fix went in originally. If a test can be devised, it would merit a separate issue (and backport).

          Show
          Myrna van Lunteren added a comment - I was contemplating this backport, but I think DERBY-4120 also should get backported. That would make the 10.6 and 10.5 build.xml files look similar with regards to OSGI elements. I already re-assigned this one, and will do the same for DERBY-4120 , hope that's OK. I could not come up with any useful automated test, and I guess no one did when the fix went in originally. If a test can be devised, it would merit a separate issue (and backport).
          Hide
          Kathey Marsden added a comment -

          This is a very simple change and easy to merge, but I don't know how to test it. Is there an easy way to test this and perhaps something we could put in our regression tests?

          Show
          Kathey Marsden added a comment - This is a very simple change and easy to merge, but I don't know how to test it. Is there an easy way to test this and perhaps something we could put in our regression tests?
          Hide
          Kathey Marsden added a comment -

          assigning to myself for back port to 10.5

          Show
          Kathey Marsden added a comment - assigning to myself for back port to 10.5
          Hide
          Kathey Marsden added a comment -

          reopen for 10.5 back port

          Show
          Kathey Marsden added a comment - reopen for 10.5 back port
          Hide
          Bryan Pendleton added a comment -

          Committed the manifest changes to the trunk as svn revision 918152.

          Show
          Bryan Pendleton added a comment - Committed the manifest changes to the trunk as svn revision 918152.
          Hide
          Bryan Pendleton added a comment -

          Attached patch will add Bundle-ManifestVersion: 2 to all the derby jar manifests.

          Show
          Bryan Pendleton added a comment - Attached patch will add Bundle-ManifestVersion: 2 to all the derby jar manifests.
          Hide
          Bryan Pendleton added a comment -

          I'll see if I can arrange for the manifest to contain bundle-manifestVersion.

          Show
          Bryan Pendleton added a comment - I'll see if I can arrange for the manifest to contain bundle-manifestVersion.

            People

            • Assignee:
              Bryan Pendleton
              Reporter:
              Alasdair Nottingham
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development