Derby
  1. Derby
  2. DERBY-4441

Change sysinfo to print out more specific JVM information

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.3.3.1, 10.4.2.1, 10.5.3.1, 10.6.1.0
    • Fix Version/s: 10.5.3.1, 10.6.1.0
    • Component/s: Tools
    • Labels:
      None
    • Issue & fix info:
      High Value Fix, Newcomer, Patch Available

      Description

      It would be nice if sysinfo printed out more specific jvm information that is provided with java -version. At least with the IBM jvm the system properties java.runtime.version and java.fullversion give some more (but not all) information. More research is needed across multiple jvms to tie it down. Alternatively sysinfo could dump all the system property information, but that could make the output pretty big and show irrelavant information in some contexts.

      1. ASF.LICENSE.NOT.GRANTED--DERBY-4441-5.diff.txt
        19 kB
        Lily Wei
      2. ASF.LICENSE.NOT.GRANTED--DERBY-4441-6.diff.txt
        20 kB
        Lily Wei
      3. DERBY-4441_diff.txt
        2 kB
        Lily Wei
      4. DERBY-4441_diff.txt
        0.7 kB
        Lily Wei
      5. DERBY-4441-2_diff.txt
        16 kB
        Lily Wei
      6. DERBY-4441-3_diff.txt
        18 kB
        Lily Wei
      7. DERBY-4441-4.diff.txt
        18 kB
        Lily Wei
      8. DERBY-4441-7.diff.txt
        18 kB
        Lily Wei
      9. suites.All.withdiff2.txt
        617 kB
        Kathey Marsden

        Issue Links

          Activity

          Kathey Marsden created issue -
          Hide
          Knut Anders Hatlen added a comment -

          Sun's JVM also has the java.runtime.version property, but not java.fullversion. Dumping the value of these properties if they are present, and ignoring them if they're not, sounds like a good idea.

          Show
          Knut Anders Hatlen added a comment - Sun's JVM also has the java.runtime.version property, but not java.fullversion. Dumping the value of these properties if they are present, and ignoring them if they're not, sounds like a good idea.
          Kathey Marsden made changes -
          Field Original Value New Value
          Link This issue relates to DERBY-1272 [ DERBY-1272 ]
          Hide
          Lily Wei added a comment -

          I did not do a lot of research. I am trying to get the feeling of whether this is the way we are thinking of solving this problem.

          From this patch: This is what I see from sysinfo:
          ------------------ Java Information ------------------
          Java Version: 1.6.0_13
          Java Vendor: Sun Microsystems Inc.
          Java home: C:\Program Files (x86)\Java\jre6
          Java classpath: .;c:/derby/trunk/tools/java/junit.jar;c:/derby/trunk/jars/sane/
          derbyrun.jar;c:/derby/trunk/jars/sane/derbyTesting.jar;c:/derby/trunk/tools/java
          /jakarta-oro-2.0.8.jar
          OS name: Windows Vista
          OS architecture: x86
          OS version: 6.0
          Java user name: lily
          Java user home: C:\Users\lily
          Java user dir: c:\derby\trunk
          java.specification.name: Java Platform API Specification
          java.specification.version: 1.6
          java.runtime.version: 1.6.0_13-b03
          java.fullversion: <info unavailable>
          ...

          Any comment is welcome.

          Show
          Lily Wei added a comment - I did not do a lot of research. I am trying to get the feeling of whether this is the way we are thinking of solving this problem. From this patch: This is what I see from sysinfo: ------------------ Java Information ------------------ Java Version: 1.6.0_13 Java Vendor: Sun Microsystems Inc. Java home: C:\Program Files (x86)\Java\jre6 Java classpath: .;c:/derby/trunk/tools/java/junit.jar;c:/derby/trunk/jars/sane/ derbyrun.jar;c:/derby/trunk/jars/sane/derbyTesting.jar;c:/derby/trunk/tools/java /jakarta-oro-2.0.8.jar OS name: Windows Vista OS architecture: x86 OS version: 6.0 Java user name: lily Java user home: C:\Users\lily Java user dir: c:\derby\trunk java.specification.name: Java Platform API Specification java.specification.version: 1.6 java.runtime.version: 1.6.0_13-b03 java.fullversion: <info unavailable> ... Any comment is welcome.
          Lily Wei made changes -
          Attachment DERBY-4441_diff.txt [ 12438209 ]
          Hide
          Kathey Marsden added a comment -

          I think if property info is not set it should be skipped instead of printing <info unavailable>. Otherwise it looks like the right general idea. With the IBM jvm you should see lots of detail in java.fullversion

          Show
          Kathey Marsden added a comment - I think if property info is not set it should be skipped instead of printing <info unavailable>. Otherwise it looks like the right general idea. With the IBM jvm you should see lots of detail in java.fullversion
          Lily Wei made changes -
          Assignee Lily Wei [ lilywei ]
          Lily Wei made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          Lily Wei added a comment -

          Good point. I can change the behavior to reflect that. Any other info we should print out with JAVA information?

          Show
          Lily Wei added a comment - Good point. I can change the behavior to reflect that. Any other info we should print out with JAVA information?
          Hide
          Lily Wei added a comment -

          Add method to handle property that is not available from the jvm. In this version, it is handling java.runtime.version and java.fullversion.

          Show
          Lily Wei added a comment - Add method to handle property that is not available from the jvm. In this version, it is handling java.runtime.version and java.fullversion.
          Lily Wei made changes -
          Attachment DERBY-4441_diff.txt [ 12438330 ]
          Lily Wei made changes -
          Issue & fix info [High Value Fix, Newcomer] [High Value Fix, Newcomer, Patch Available]
          Hide
          Lily Wei added a comment -

          Will someone please try ibm jvm, mac and any other jvm to see. Also, please let me know if there is any useful property to use. I did not run any test yet.

          Show
          Lily Wei added a comment - Will someone please try ibm jvm, mac and any other jvm to see. Also, please let me know if there is any useful property to use. I did not run any test yet.
          Hide
          Kathey Marsden added a comment -

          Hi Lily,

          It looks great with the IBM 1.6, 1.5 and 1.42 jvms. Here is the 1.6 output.

          [C:/svn4/trunk] java org.apache.derby.tools.sysinfo
          ------------------ Java Information ------------------
          Java Version: 1.6.0
          Java Vendor: IBM Corporation
          Java home: C:\p4\marsden_trunk\ibm16\jre
          Java classpath: .;C:/svn4/trunk/jars/sane/derbytools.jar;C:/svn4/trunk/jars/sane/derbyrun.jar;C:/svn4/trunk/jars/sane/d
          erbyclient.jar;C:/svn4/trunk/jars/sane/derbynet.jar;C:/svn4/trunk/jars/sane/derbyTesting.jar;C:/svn4/trunk/tools/java/ju
          nit.jar;c:/svn/tools/jakarta-oro-2.0.8.jar
          OS name: Windows XP
          OS architecture: x86
          OS version: 5.1 build 2600 Service Pack 3
          Java user name: kmarsden
          Java user home: C:\Documents and Settings\kmarsden
          Java user dir: C:\svn4\trunk
          java.specification.name: Java Platform API Specification
          java.specification.version: 1.6
          java.runtime.version: jvmwi3260sr5-20090519_35743
          java.fullversion: J2RE 1.6.0 IBM J9 2.4 Windows XP x86-32 jvmwi3260sr5-20090519_35743 (JIT enabled, AOT enabled)
          J9VM - 20090519_035743_lHdSMr
          JIT - r9_20090518_2017
          GC - 20090417_AA
          --------- Derby Information --------
          JRE - JDBC: Java SE 6 - JDBC 4.0
          [C:\svn4\trunk\jars\sane\derby.jar] 10.6.0.0 alpha - (921154M)
          ...

          Show
          Kathey Marsden added a comment - Hi Lily, It looks great with the IBM 1.6, 1.5 and 1.42 jvms. Here is the 1.6 output. [C:/svn4/trunk] java org.apache.derby.tools.sysinfo ------------------ Java Information ------------------ Java Version: 1.6.0 Java Vendor: IBM Corporation Java home: C:\p4\marsden_trunk\ibm16\jre Java classpath: .;C:/svn4/trunk/jars/sane/derbytools.jar;C:/svn4/trunk/jars/sane/derbyrun.jar;C:/svn4/trunk/jars/sane/d erbyclient.jar;C:/svn4/trunk/jars/sane/derbynet.jar;C:/svn4/trunk/jars/sane/derbyTesting.jar;C:/svn4/trunk/tools/java/ju nit.jar;c:/svn/tools/jakarta-oro-2.0.8.jar OS name: Windows XP OS architecture: x86 OS version: 5.1 build 2600 Service Pack 3 Java user name: kmarsden Java user home: C:\Documents and Settings\kmarsden Java user dir: C:\svn4\trunk java.specification.name: Java Platform API Specification java.specification.version: 1.6 java.runtime.version: jvmwi3260sr5-20090519_35743 java.fullversion: J2RE 1.6.0 IBM J9 2.4 Windows XP x86-32 jvmwi3260sr5-20090519_35743 (JIT enabled, AOT enabled) J9VM - 20090519_035743_lHdSMr JIT - r9_20090518_2017 GC - 20090417_AA --------- Derby Information -------- JRE - JDBC: Java SE 6 - JDBC 4.0 [C:\svn4\trunk\jars\sane\derby.jar] 10.6.0.0 alpha - (921154M) ...
          Hide
          Lily Wei added a comment -

          Along with Main.java change, all the policy files should include java.runtime.version and java.fullversion. This patch include that.
          The derbyall test passed with this patch. I am running Suites.All test suit.

          Show
          Lily Wei added a comment - Along with Main.java change, all the policy files should include java.runtime.version and java.fullversion. This patch include that. The derbyall test passed with this patch. I am running Suites.All test suit.
          Lily Wei made changes -
          Attachment DERBY-4441-2_diff.txt [ 12438483 ]
          Hide
          Kathey Marsden added a comment -

          Lily told me this morning that with this patch she was seeing a hang in memory.TriggerTests. I applied the 2_diff patch and ran the test with no problems. I will run the full suites.All now.

          Show
          Kathey Marsden added a comment - Lily told me this morning that with this patch she was seeing a hang in memory.TriggerTests. I applied the 2_diff patch and ran the test with no problems. I will run the full suites.All now.
          Hide
          Lily Wei added a comment -

          Thank you so much, Kathey. It is so great to know this. I am still in the middle of finding out the problem with my Vista. Vista is a challenging operating system.

          Show
          Lily Wei added a comment - Thank you so much, Kathey. It is so great to know this. I am still in the middle of finding out the problem with my Vista. Vista is a challenging operating system.
          Hide
          Kathey Marsden added a comment -

          My suites.All run was less than successful. This morning my screen was black and I had to reboot. The last output of my run was:

          testPositionString used 656 ms .
          testPositionStringWithUnicode used 2032 ms .
          testPositionClob

          I am not sure how long it took for things to go south. Before that, there were failures in
          DerbyNetClient/SysinfoTest
          testSysinfo used 1984 ms F.
          testSysinfoMethod used 47 ms F.
          testSysinfoLocale used 2109 ms F.
          testSysinfo used 1969 ms F.
          testSysinfoMethod used 47 ms F.

          but that did not seem to be what held up the run as it continued for some time after that.

          I will try the one test with testPositionClob and see if it runs ok and then do a full rerun. I can't imagine how a sysinfo change could cause such problems.

          Show
          Kathey Marsden added a comment - My suites.All run was less than successful. This morning my screen was black and I had to reboot. The last output of my run was: testPositionString used 656 ms . testPositionStringWithUnicode used 2032 ms . testPositionClob I am not sure how long it took for things to go south. Before that, there were failures in DerbyNetClient/SysinfoTest testSysinfo used 1984 ms F. testSysinfoMethod used 47 ms F. testSysinfoLocale used 2109 ms F. testSysinfo used 1969 ms F. testSysinfoMethod used 47 ms F. but that did not seem to be what held up the run as it continued for some time after that. I will try the one test with testPositionClob and see if it runs ok and then do a full rerun. I can't imagine how a sysinfo change could cause such problems.
          Hide
          Lily Wei added a comment -

          Oh, no. It is a great things we have regression tests to catch for things like this.
          I will run only DerbyNetClient/Sysinfo to see which policy file change causes such severe behavior. From there, I will also check where it hangs on my machine to see the impact of policy file changes.

          Thank you so much Kathey for looking into this.

          Show
          Lily Wei added a comment - Oh, no. It is a great things we have regression tests to catch for things like this. I will run only DerbyNetClient/Sysinfo to see which policy file change causes such severe behavior. From there, I will also check where it hangs on my machine to see the impact of policy file changes. Thank you so much Kathey for looking into this.
          Hide
          Kathey Marsden added a comment -

          Lily, I did another run and this time had none of the strange behavior, but just the six sysinfo failures reported in the attached suites.Allwithdiff2.txt. Maybe I too am having trouble with my machine and actually have a new one in a box here on my desk. After you fix the sysinfo failures, I'll give it another run on the new machine to make sure.

          Show
          Kathey Marsden added a comment - Lily, I did another run and this time had none of the strange behavior, but just the six sysinfo failures reported in the attached suites.Allwithdiff2.txt. Maybe I too am having trouble with my machine and actually have a new one in a box here on my desk. After you fix the sysinfo failures, I'll give it another run on the new machine to make sure.
          Kathey Marsden made changes -
          Attachment suites.All.withdiff2.txt [ 12439095 ]
          Hide
          Kathey Marsden added a comment -

          I wanted to mention that the black screen and necessary reboot happened to me running tests with a completely different patch, so I think it is unrelated to Lily's patch, but rather some hardware problem with the machine.

          Show
          Kathey Marsden added a comment - I wanted to mention that the black screen and necessary reboot happened to me running tests with a completely different patch, so I think it is unrelated to Lily's patch, but rather some hardware problem with the machine.
          Hide
          Lily Wei added a comment -

          Add permission for java.io.FilePermission "$

          {derby.system.home}

          $

          {/}

          derby.log", "read, write, delete" with the new patch.

          I run suites all and derbyall test suites. Both passed with Windows 7 on sun jvm.

          Show
          Lily Wei added a comment - Add permission for java.io.FilePermission "$ {derby.system.home} $ {/} derby.log", "read, write, delete" with the new patch. I run suites all and derbyall test suites. Both passed with Windows 7 on sun jvm.
          Lily Wei made changes -
          Attachment DERBY-4441-3_diff.txt [ 12439926 ]
          Hide
          Lily Wei added a comment -

          Would someone help me look at this patch? I will really appricated help at this point. Thank you so much!

          Show
          Lily Wei added a comment - Would someone help me look at this patch? I will really appricated help at this point. Thank you so much!
          Hide
          Knut Anders Hatlen added a comment -

          Hi Lily,

          The #3 patch looks safe to me. My only comments are

          • the new method printPropertyIfNotNull() is placed further to the left than the surrounding methods
          • the @param tags in the two getJavaProperty() methods are empty. I think this will cause javadoc warnings
          • it would be good if the javadoc comment for the two-argument getJavaProperty() method explained the purpose of the nullUnavailable parameter
          Show
          Knut Anders Hatlen added a comment - Hi Lily, The #3 patch looks safe to me. My only comments are the new method printPropertyIfNotNull() is placed further to the left than the surrounding methods the @param tags in the two getJavaProperty() methods are empty. I think this will cause javadoc warnings it would be good if the javadoc comment for the two-argument getJavaProperty() method explained the purpose of the nullUnavailable parameter
          Hide
          Lily Wei added a comment -

          Thank you, Knut.
          These are very good suggestion. I will fix the code and run tests after that. Does anyone run it against IBM jvm? I did not get any failure for SysInfoTest from sun jvm. However, I am not sure how they will behave with IBM jvm.

          Show
          Lily Wei added a comment - Thank you, Knut. These are very good suggestion. I will fix the code and run tests after that. Does anyone run it against IBM jvm? I did not get any failure for SysInfoTest from sun jvm. However, I am not sure how they will behave with IBM jvm.
          Hide
          Lily Wei added a comment -

          Thanks, Knut.
          I include the new patch for this bug.
          The changes include:
          1. Move places further left for printPropertyIfNotNull()
          2. add @param tags or two getJavProperty methods. Don't want to have java warning.
          3.Add the comment to explain nullUnavailable parameter for the two-argument getJavaProperty() method.

          I run tests for Suits.all and derbyall. They passed with sun jvm on Windows 7 env.
          I did not run test against ibm jvm. The patch is ready if we don't have any diff against ibm jvm.

          Show
          Lily Wei added a comment - Thanks, Knut. I include the new patch for this bug. The changes include: 1. Move places further left for printPropertyIfNotNull() 2. add @param tags or two getJavProperty methods. Don't want to have java warning. 3.Add the comment to explain nullUnavailable parameter for the two-argument getJavaProperty() method. I run tests for Suits.all and derbyall. They passed with sun jvm on Windows 7 env. I did not run test against ibm jvm. The patch is ready if we don't have any diff against ibm jvm.
          Lily Wei made changes -
          Attachment DERBY-4441-4.diff.txt [ 12440514 ]
          Hide
          Myrna van Lunteren added a comment -

          after applying the patch, I ran with both ibm 1.6 and ibm 1.5 and jdk 1.6 with my machine.
          The patched test passes with jdk 1.6, but fails with ibm 1.6 and ibm 1.5.
          I cannot look into why right now.

          Show
          Myrna van Lunteren added a comment - after applying the patch, I ran with both ibm 1.6 and ibm 1.5 and jdk 1.6 with my machine. The patched test passes with jdk 1.6, but fails with ibm 1.6 and ibm 1.5. I cannot look into why right now.
          Myrna van Lunteren made changes -
          Comment [ hm...I get the same without the patch.
          When I was using the patch, I tried classes and jars, insane and sane...
          I guess this is what Jayaram is seeing also... ]
          Hide
          Lily Wei added a comment -

          Thanks to Kathey. I have ibm 1.6 jvm. Make changes on policy and make SysinfoTest.sysinfotest passed. However, there is still one failure on SysinfoTest with ibm 1.6 jvm

          Show
          Lily Wei added a comment - Thanks to Kathey. I have ibm 1.6 jvm. Make changes on policy and make SysinfoTest.sysinfotest passed. However, there is still one failure on SysinfoTest with ibm 1.6 jvm
          Lily Wei made changes -
          Attachment DERBY-4441-5.diff.txt [ 12441656 ]
          Hide
          Lily Wei added a comment -

          With this patch, it passed all the tests for derbyall and suites.all. However, with ibm 1.6 jvm, SysinfoTest.testSysinfoLocale failed with expect <15> was <1>. I think this failure happends against german locale when connect to network server with ibm 1.6 jvm with windows 7 64 bits platform. However, just want to provide the current patch so it is available.

          Show
          Lily Wei added a comment - With this patch, it passed all the tests for derbyall and suites.all. However, with ibm 1.6 jvm, SysinfoTest.testSysinfoLocale failed with expect <15> was <1>. I think this failure happends against german locale when connect to network server with ibm 1.6 jvm with windows 7 64 bits platform. However, just want to provide the current patch so it is available.
          Lily Wei made changes -
          Attachment DERBY-4441-6.diff.txt [ 12441985 ]
          Hide
          Kathey Marsden added a comment -

          Hi Lily I applied patch 5 and tested SysinfoTest with IBM 1.6 on XP
          java version "1.6.0"
          Java(TM) SE Runtime Environment (build pwi3260sr7-20091217_01(SR7))
          IBM J9 VM (build 2.4, JRE 1.6.0 IBM J9 2.4 Windows XP x86-32 jvmwi3260sr7-200912
          14_49398 (JIT enabled, AOT enabled)
          J9VM - 20091214_049398
          JIT - r9_20091123_13891
          GC - 20091111_AA)
          JCL - 20091202_01

          It passed fine and I agree your failure is probably an IB47 M 1.6 on Windows 7 64bit issue, because a similar problem was reported from someone else running tests on Windows 7 64 bit. I think you should file a separate issue for that, but it should not hold your patch up because people are seeing it without your patch.

          I was getting ready to commit your 5 patch, but see now there is a 6 patch. What is the difference between 5 and 6?

          Show
          Kathey Marsden added a comment - Hi Lily I applied patch 5 and tested SysinfoTest with IBM 1.6 on XP java version "1.6.0" Java(TM) SE Runtime Environment (build pwi3260sr7-20091217_01(SR7)) IBM J9 VM (build 2.4, JRE 1.6.0 IBM J9 2.4 Windows XP x86-32 jvmwi3260sr7-200912 14_49398 (JIT enabled, AOT enabled) J9VM - 20091214_049398 JIT - r9_20091123_13891 GC - 20091111_AA) JCL - 20091202_01 It passed fine and I agree your failure is probably an IB47 M 1.6 on Windows 7 64bit issue, because a similar problem was reported from someone else running tests on Windows 7 64 bit. I think you should file a separate issue for that, but it should not hold your patch up because people are seeing it without your patch. I was getting ready to commit your 5 patch, but see now there is a 6 patch. What is the difference between 5 and 6?
          Hide
          Lily Wei added a comment -

          Thank you so much, Kathey. The difference between 5 and 6 is taking out of write permission for java.runtime.version and java.fullversion. I think version 6 is cleaner than 5. It is so good to learn that it is ready to commit.
          I will create another issue for SysinfoTest.testsysinfoLocale failed with IB47M 1.6 on Windows 7 64 bit.

          Show
          Lily Wei added a comment - Thank you so much, Kathey. The difference between 5 and 6 is taking out of write permission for java.runtime.version and java.fullversion. I think version 6 is cleaner than 5. It is so good to learn that it is ready to commit. I will create another issue for SysinfoTest.testsysinfoLocale failed with IB47M 1.6 on Windows 7 64 bit.
          Hide
          Kathey Marsden added a comment -

          Ok. Thanks Lily, I will pick up the 6 patch and commit it Monday, so this useful enhancement will make 10.6. Have a great weekend.

          Show
          Kathey Marsden added a comment - Ok. Thanks Lily, I will pick up the 6 patch and commit it Monday, so this useful enhancement will make 10.6. Have a great weekend.
          Hide
          Lily Wei added a comment -

          When looking at the regression run. Revision 935871 passed on jvm 1.4, 1.6, javame. It failed on jvm 1.5 with 49 failure and 6 errors. i.e. changeEncryptionFromNone.
          For ibm jvm, revision 935786 seems to be ok on Linux. It did not have windows result yet.
          I am attaching the 10.5 port in case it is safe to use it.

          Show
          Lily Wei added a comment - When looking at the regression run. Revision 935871 passed on jvm 1.4, 1.6, javame. It failed on jvm 1.5 with 49 failure and 6 errors. i.e. changeEncryptionFromNone. For ibm jvm, revision 935786 seems to be ok on Linux. It did not have windows result yet. I am attaching the 10.5 port in case it is safe to use it.
          Lily Wei made changes -
          Attachment DERBY-4441-7.diff.txt [ 12442435 ]
          Hide
          Kim Haase added a comment -

          It looks as if the result of this fix is to add one line (java.runtime.version) to the sysinfo output. Is this correct?

          We need to change the sysinfo example in the Tools manual slightly to reflect this change. I'll file a doc issue.

          Show
          Kim Haase added a comment - It looks as if the result of this fix is to add one line (java.runtime.version) to the sysinfo output. Is this correct? We need to change the sysinfo example in the Tools manual slightly to reflect this change. I'll file a doc issue.
          Hide
          Lily Wei added a comment -

          Thanks, Kim. The result of this fix is to add one line (java.runtime.version) to the sysinfo output for sun jvm. For ibm jvm, it will add two line (java.runtime.version and java.fullversion)

          This is the example from sun jvm output for sysinfo:
          Java user dir: c:\derby\trunk\testtmp
          java.specification.name: Java Platform API Specification
          java.specification.version: 1.6
          java.runtime.version: 1.6.0_17-b04 <<<====NEW======>>>

          This is the example for ibm jvm output for sysinfo:
          Java user dir: c:\derby\trunk
          java.specification.name: Java Platform API Specification
          java.specification.version: 1.6
          java.runtime.version: jvmwi3260sr7-20091214_49398 <<<====NEW======>>>
          java.fullversion: JRE 1.6.0 IBM J9 2.4 Windows 7 x86-32 jvmwi3260sr7-20091214_49 <<<====NEW======>>>
          398 (JIT enabled, AOT enabled) <<<====NEW======>>>
          J9VM - 20091214_049398 <<<====NEW======>>>
          JIT - r9_20091123_13891 <<<====NEW======>>>
          GC - 20091111_AA <<<====NEW======>>>

          Kathey also suggests to add more info to the change of policy file. Will you mind include that in the doc as well.

          Show
          Lily Wei added a comment - Thanks, Kim. The result of this fix is to add one line (java.runtime.version) to the sysinfo output for sun jvm. For ibm jvm, it will add two line (java.runtime.version and java.fullversion) This is the example from sun jvm output for sysinfo: Java user dir: c:\derby\trunk\testtmp java.specification.name: Java Platform API Specification java.specification.version: 1.6 java.runtime.version: 1.6.0_17-b04 <<<====NEW======>>> This is the example for ibm jvm output for sysinfo: Java user dir: c:\derby\trunk java.specification.name: Java Platform API Specification java.specification.version: 1.6 java.runtime.version: jvmwi3260sr7-20091214_49398 <<<====NEW======>>> java.fullversion: JRE 1.6.0 IBM J9 2.4 Windows 7 x86-32 jvmwi3260sr7-20091214_49 <<<====NEW======>>> 398 (JIT enabled, AOT enabled) <<<====NEW======>>> J9VM - 20091214_049398 <<<====NEW======>>> JIT - r9_20091123_13891 <<<====NEW======>>> GC - 20091111_AA <<<====NEW======>>> Kathey also suggests to add more info to the change of policy file. Will you mind include that in the doc as well.
          Hide
          Lily Wei added a comment -

          It looks like regression is ok and 10.5 patch is attached. I am closing this issue for now.

          Show
          Lily Wei added a comment - It looks like regression is ok and 10.5 patch is attached. I am closing this issue for now.
          Lily Wei made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Fix Version/s 10.6.0.0 [ 12313727 ]
          Resolution Fixed [ 1 ]
          Hide
          Kathey Marsden added a comment -

          Thanks Lily for the fix

          Show
          Kathey Marsden added a comment - Thanks Lily for the fix
          Kathey Marsden made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Kathey Marsden added a comment -

          reopen for 10.5 backport

          Show
          Kathey Marsden added a comment - reopen for 10.5 backport
          Kathey Marsden made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Assignee Lily Wei [ lilywei ] Kathey Marsden [ kmarsden ]
          Kathey Marsden made changes -
          Link This issue is required by DERBY-4728 [ DERBY-4728 ]
          Kathey Marsden made changes -
          Fix Version/s 10.5.3.1 [ 12314182 ]
          Hide
          Kathey Marsden added a comment -

          closing back up after port.

          Show
          Kathey Marsden added a comment - closing back up after port.
          Kathey Marsden made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Assignee Kathey Marsden [ kmarsden ] Lily Wei [ lilywei ]
          Resolution Fixed [ 1 ]
          Lily Wei made changes -
          Comment [ Thank you for reviewing the patch, Kristian. I will prefer using spaces for indentation as well.
          However, for file BaseDataFileFactory.java, there are way too many lines changes if I save spaces as tab for indentation using editor/IDE to insert spaces when I press the TAB key. That is why both spaces and tab were using for the patch. I think it is also important to keep history as we introduce insert spaces as tab for indentation going forward. We could have a project that only changes tab to spaces.
          ]
          Gavin made changes -
          Workflow jira [ 12481912 ] Default workflow, editable Closed status [ 12798612 ]

            People

            • Assignee:
              Lily Wei
              Reporter:
              Kathey Marsden
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development