[DERBY-4293] Mutable public static variables

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 10.6.1.0
• Fix Version/s: 10.6.1.0
• Component/s: Build tools, Network Client, SQL, Store
• Bug behavior facts: Security
• Assignee: Knut Anders Hatlen
• Reporter: Sebb
• Created: 27/Jun/09 23:51
• Updated: 21/Jan/11 17:52
• Resolved: 04/Dec/09 00:44

Description

There are quite a few instances of public static fields which appear to be intended to be constant, but which are not final.

The code would be safer if all the constant fields were made final.

Patch to follow for some of the problem fields.

The following also ought to be fixed:

org.apache.derby.iapi.services.property.PropertyUtil.servicePropertyList (e.g. use an accessor to lookup the values)
org.apache.derby.iapi.types.JSQLType.primitiveNames (ditto)