Derby
  1. Derby
  2. DERBY-4278

Batch inserts with Clobs fails with the embedded driver

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.5.1.1, 10.6.1.0
    • Fix Version/s: 10.5.2.0, 10.6.1.0
    • Component/s: JDBC
    • Labels:
      None
    • Urgency:
      Urgent
    • Bug behavior facts:
      Regression

      Description

      Batch inserts with Clobs fail because Derby is unable to determine if it should write the Clob stream header formats using the old 10.4 style format or the new 10.5 format.
      More specifically, the access mode (soft upgrade or not) hasn't been set specifically by Derby before the stream header has to be generated, and there isn't enough context to determine the mode at generation time.

      Bug was reported on derby-user: http://www.nabble.com/Hibernate-%2B-Derby---Unable-to-determine-stream-header-for-hibernate-type-%27text%27-td24099674.html

      The bug was reported for Derby used with Hibernate. Possible workarounds are to use the client driver or to avoid using batched inserts with Clobs (i.e. don't use batched inserts, which may degrade performance, or use a different data type).

      1. derby-4278-1a-regression_test.diff
        4 kB
        Kristian Waagan
      2. derby-4278-2a-fix.diff
        3 kB
        Kristian Waagan

        Activity

        Hide
        Kristian Waagan added a comment -

        Attached regression tests for the bug as patch 1a.
        The patch must be committed together with the fix.

        Show
        Kristian Waagan added a comment - Attached regression tests for the bug as patch 1a. The patch must be committed together with the fix.
        Hide
        Kristian Waagan added a comment -

        Attaching fix for the bug as patch 2a.
        The problem is solved by explicitly telling the SQLCLob data object whether the database being accessed is accessed in soft upgrade mode or not. This information is readily available in EmbedPreparedStatement. I chose to determine the mode lazily, so the method (isSoftUpgraded) should be used instead of referencing the variable directly.

        Running regression tests.
        Patch ready for review.

        Show
        Kristian Waagan added a comment - Attaching fix for the bug as patch 2a. The problem is solved by explicitly telling the SQLCLob data object whether the database being accessed is accessed in soft upgrade mode or not. This information is readily available in EmbedPreparedStatement. I chose to determine the mode lazily, so the method (isSoftUpgraded) should be used instead of referencing the variable directly. Running regression tests. Patch ready for review.
        Hide
        Kristian Waagan added a comment -

        Regression tests passed.

        Show
        Kristian Waagan added a comment - Regression tests passed.
        Hide
        Kristian Waagan added a comment -

        I'm marking this issue as Urgent as it seems to be triggered with default configuration using Derby with Hibernate (and Clobs in the table of course). It is also a regression, introduced through the new Clob header format code.
        Finally, the bug was reported by a user.

        Show
        Kristian Waagan added a comment - I'm marking this issue as Urgent as it seems to be triggered with default configuration using Derby with Hibernate (and Clobs in the table of course). It is also a regression, introduced through the new Clob header format code. Finally, the bug was reported by a user.
        Hide
        Kristian Waagan added a comment -

        User reported that his application ran successfully with the fix applied (see the thread from the issue description).

        Committed patches 1a and 2a to trunk with revision 790135.
        Awaiting test results before back-porting to 10.5.

        Show
        Kristian Waagan added a comment - User reported that his application ran successfully with the fix applied (see the thread from the issue description). Committed patches 1a and 2a to trunk with revision 790135. Awaiting test results before back-porting to 10.5.
        Hide
        Kristian Waagan added a comment -

        Merged fix (patches 1a and 2a) to 10.5 with revision 791403.

        Show
        Kristian Waagan added a comment - Merged fix (patches 1a and 2a) to 10.5 with revision 791403.

          People

          • Assignee:
            Kristian Waagan
            Reporter:
            Kristian Waagan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development