Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-4048

Update Statistics code in AlterTableConstantAction should use execute transaction rather than compile transaction

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.5.1.1
    • Fix Version/s: 10.5.1.1
    • Component/s: SQL
    • Labels:
      None

      Description

      DERBY-269 provided a new stored procedure SYSCS_UTIL.SYSCS_UPDATE_STATISTICS to update the statistics. The code to do the work was added in AlterTableConstantAction and the name of new method in that class is updateStatistics(Activation activation). This code was copied from an existing unused class execute/UpdateStatisticsConstantAction.java(that unused class has been removed from Derby code).

      The copied code in AlterTableConstantAction:updateStatistics gets compile transaction as shown below to do the work of updating the statistics.
      TransactionController tc = lcc.getTransactionCompile();
      The javadoc for LangaugeConnectionContext for getTransactionCompile says following
      /**
      Get the transaction controller to use with this language connection
      context at compile time.
      */
      TransactionController getTransactionCompile();

      I think we should be using TransactionController tc = lcc.getTransactionExecute() to do the work since we are not in the compile phase. The rest of the code in AlterTableConstantAction uses lcc.getTransactionExecute to get the transaction controller.

      I will make the changes in AlterTableConstantAction.updateStatistics to use getTransactionExecute and will run the existing tests to make sure nothing breaks.

      I ran into this issue of getTransactionExecute vs getTransactionCompile while working on DERBY-3788 (provide a zero-admin way of updating the statistics). While trying to run the statistics inline duirn the compile phase of a SELECT query, I ran into exception that statistics can't be updated because we are in read-only mode. But if I change the AlterTableConstantAction to use getTransactionExecute, then I do not run into the read-only mode exception.

      Please let me know if anyone has any comments on this. I will run the existing tests and if no failures, then I will go ahead and commit the change of using getTransactionExecute rather than getTransactionCompile in AlterTableConstantAction:updateStatistics

        Attachments

        1. DERBY4048_useExecuteTran_diff.txt
          0.7 kB
          Mamta A. Satoor

          Activity

            People

            • Assignee:
              mamtas Mamta A. Satoor
              Reporter:
              mamtas Mamta A. Satoor
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: