[DERBY-3784] ImportExportTest doesn't detect lack of expected errors

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 10.5.1.1
• Fix Version/s: 10.5.1.1
• Component/s: Test
• Assignee: Knut Anders Hatlen
• Reporter: Knut Anders Hatlen
• Created: 18/Jul/08 21:40
• Updated: 04/May/09 18:21
• Resolved: 23/Jul/08 08:38

Description

I observed that ImportExportTest contains many test cases which do try/catch/assertSQLException, but none of them call fail() at the end of the try block. Example:

public void testEarlyEndOfFile() throws Exception {
Connection c = getConnection();
try

{ doImportFromFile(c, "extin/EndOfFile.txt" , "T4" , null , null , null, 0); }

catch (SQLException e)

{ assertSQLState("XIE0E", e); }

}

I think this means that if the expected exception isn't thrown the test still passes.