[DERBY-3537] Invalid use shutdown authentication checks in NetworkServerControlImpl.directShutdown()

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 10.4.1.3
• Component/s: Network Server
• Assignee: Martin Zaun
• Reporter: Daniel John Debrunner
• Created: 14/Mar/08 03:28
• Updated: 21/Jan/11 17:51
• Resolved: 01/Apr/08 23:16

Description

If ClientThread hits an SSLException exception it will call NetworkServerControlImpl.directShutdown().

DERBY-2109 added privilege checking to directShutdown() that includes authentication.

I can't see how this call by ClientThread can be valid. Authentication is not required to start the network server, thus a NetworkServerControl with no user,password may be used and thus passed onto directShutdown() failing authentication and then failing to perform the failed shutdown?

I think the error was adding the privilege check in DERBY-2109, it looks like this method is for use only within the network server (actually this is the only use of it), maybe the correct security mechanism would have been to make the method package private?