Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-3525

Remove unneeded code to get JDBC level in BrokeredConnection and BrokeredStatement classes

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 10.5.1.1
    • Fix Version/s: 10.3.3.0, 10.4.1.3, 10.5.1.1
    • Component/s: JDBC
    • Labels:
      None

      Description

      BrokeredConnection has a method called getJDBCLevel() whose only purpose is to provide a value that can be stored in BrokeredStatement.jdbcLevel. This field is only used once, in BrokeredStatement.createDuplicateStatement():

      if (jdbcLevel == 2)
      newStatement = conn.createStatement(resultSetType, resultSetConcurrency);
      else
      newStatement = conn.createStatement(resultSetType, resultSetConcurrency,
      resultSetHoldability);

      Since getJDBCLevel() only returns 2 if Java version 1.3 is used, and Derby doesn't support Java 1.3 any more, BrokeredConnection.getJDBCLevel() and BrokeredStatement.jdbcLevel could be removed.

        Attachments

        1. derby-3525_diff.txt
          11 kB
          Katherine Marsden

          Issue Links

            Activity

              People

              • Assignee:
                kmarsden Katherine Marsden
                Reporter:
                knutanders Knut Anders Hatlen
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: