Derby
  1. Derby
  2. DERBY-3421

Remove unused code for caching of connect bytes

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.3.2.1, 10.4.1.3
    • Fix Version/s: 10.3.3.0, 10.4.1.3
    • Component/s: Network Client
    • Labels:
      None

      Description

      The client driver has code for caching connect bytes, but it is not used.
      This unused code clutters the rest of the code and makes it harder to understand.

      Secondly, the variable used to determine if the cached connect bytes can be used is public in am.Connection.

      If someone has historic information about this feature, it would be nice if they could add the information to this Jira.

      1. derby-3421-1a-removal.diff
        10 kB
        Kristian Waagan
      2. derby-3421-1a-removal.stat
        0.1 kB
        Kristian Waagan
      3. derby-3421-1b-removal.diff
        11 kB
        Kristian Waagan
      4. derby-3421-1b-removal.stat
        0.2 kB
        Kristian Waagan

        Issue Links

          Activity

          Hide
          Kristian Waagan added a comment -

          'derby-3421-1a-removal.diff' removes the code related to caching of connect bytes.
          I'm running tests for good measure.

          If someone think this is an important feature, please create a new Jira for enabling it and close this one as invalid.
          I will wait for a little while before I commit the patch.

          thanks,

          Show
          Kristian Waagan added a comment - 'derby-3421-1a-removal.diff' removes the code related to caching of connect bytes. I'm running tests for good measure. If someone think this is an important feature, please create a new Jira for enabling it and close this one as invalid. I will wait for a little while before I commit the patch. thanks,
          Hide
          Kristian Waagan added a comment -

          Tests ran fine with the patch applied (Solaris 10, Sun JDK 1.6).

          Show
          Kristian Waagan added a comment - Tests ran fine with the patch applied (Solaris 10, Sun JDK 1.6).
          Hide
          Knut Anders Hatlen added a comment -

          +1 to commit. It doesn't sound like an important feature, and if someone thinks it is, they can always get the code back from svn and do what it takes to enable it. Since it's not used now, it's better to remove it so that the code is easier to understand.

          I think you can also remove NetConnectionReply.verifyDeferredReset() since you removed the only code that calls it.

          Show
          Knut Anders Hatlen added a comment - +1 to commit. It doesn't sound like an important feature, and if someone thinks it is, they can always get the code back from svn and do what it takes to enable it. Since it's not used now, it's better to remove it so that the code is easier to understand. I think you can also remove NetConnectionReply.verifyDeferredReset() since you removed the only code that calls it.
          Hide
          Kristian Waagan added a comment -

          Thanks for catching the other method that can be removed Knut Anders.

          'derby-3421-1b-removal.diff' removes NetConnectionReply.verifyDeferredReset as well, nothing else is changed.

          Show
          Kristian Waagan added a comment - Thanks for catching the other method that can be removed Knut Anders. 'derby-3421-1b-removal.diff' removes NetConnectionReply.verifyDeferredReset as well, nothing else is changed.
          Hide
          Kristian Waagan added a comment -

          Committed 'derby-3421-1b-removal.diff' to trunk with revision 628679.
          I don't expect more work to be done on this issue.

          Show
          Kristian Waagan added a comment - Committed 'derby-3421-1b-removal.diff' to trunk with revision 628679. I don't expect more work to be done on this issue.
          Hide
          Kathey Marsden added a comment -

          Committed revision 651835 to 10.3

          Show
          Kathey Marsden added a comment - Committed revision 651835 to 10.3

            People

            • Assignee:
              Kristian Waagan
              Reporter:
              Kristian Waagan
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development