Derby
  1. Derby
  2. DERBY-3368

Threading issue with DependencyManager may cause in-memory dependencies to be lost.

    Details

    • Urgency:
      Normal
    • Bug behavior facts:
      Wrong query result

      Description

      When a thread compiles a language prepared statement P a set of in-memory Dependency objects is created, e.g. if P accesses table A

      Dependency

      {P depends on A}

      When this Dependency is added to the dependency manager if an equivalent one (same provider and dependent) exists then the duplicate will not be added.

      The StatementContext keeps track of these added Dependency so that if the compilation fails the Dependency will be removed, comparing by the exact same Dependency object (not by equivalence).

      If a thread T1 compiling P fails, then another thread may try to compile P (same object). If this second thread T2 compiles successfully the following could happen:

      1) T1 compiles P creates Dependency {P depends on A}

      in dependency manager
      2) T1 fails to compile, but does not yet execute its cleanup
      3) T2 compiles P successfully, attempts to add Dependency

      {P depends on A} to the manager but it is a duplicate so T1's version is left and T2's is not added.
      4) T1 completes its cleanup and removes Dependency {P depends on A}

      5) P no longer depends on A

      Concern is that the security system GRANT/REVOKE is based upon the dependency manager as well as correctness for indexes (e.g. this could cause a recompile to be missed for an INSERT table when an index is added).

      For this to actually happen there has to be a situation where one thread (connection) can compile a statement that another one fails on (and be compiling at near identical times). I haven't got a reproducible case yet, but I can get two statements to be compiling the same statement plan (P).

        Issue Links

          Activity

          Daniel John Debrunner created issue -
          Daniel John Debrunner made changes -
          Field Original Value New Value
          Link This issue relates to DERBY-3102 [ DERBY-3102 ]
          Daniel John Debrunner made changes -
          Link This issue relates to DERBY-2380 [ DERBY-2380 ]
          Kathey Marsden made changes -
          Derby Categories [High Value Fix]
          Dag H. Wanvik made changes -
          Issue & fix info [High Value Fix]
          Tiago R. Espinha made changes -
          Urgency Normal
          Kathey Marsden made changes -
          Labels derby_triage10_5_2
          Kathey Marsden made changes -
          Affects Version/s 10.2.2.0 [ 12312027 ]
          Kathey Marsden made changes -
          Labels derby_triage10_5_2 derby_triage10_10 derby_triage10_5_2
          Bug behavior facts Wrong query result [ 10366 ]
          Issue & fix info High Value Fix [ 10422 ]
          Gavin made changes -
          Workflow jira [ 12422418 ] Default workflow, editable Closed status [ 12802009 ]

            People

            • Assignee:
              Unassigned
              Reporter:
              Daniel John Debrunner
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Development